Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ie11 has rewrite test #25342

Merged
merged 2 commits into from
May 22, 2021
Merged

Fix ie11 has rewrite test #25342

merged 2 commits into from
May 22, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 21, 2021

This updates the rewrites-has-condition tests to not rely on the browser.log method since it's not available with ie11

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member Author

ijjk commented May 22, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js fix/ie11-test Change
buildDuration 11.6s 11.5s -115ms
buildDurationCached 3.5s 3.2s -240ms
nodeModulesSize 46.7 MB 46.7 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/ie11-test Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.128 2.103 -0.02
/ avg req/sec 1175.02 1188.81 +13.79
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.147 1.102 -0.04
/error-in-render avg req/sec 2179.87 2268.09 +88.22
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/ie11-test Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/ie11-test Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/ie11-test Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/ie11-test Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/ie11-test Change
index.html gzip 559 B 559 B ✓
link.html gzip 567 B 567 B ✓
withRouter.html gzip 555 B 555 B ✓
Overall change 1.68 kB 1.68 kB ✓
Serverless Mode
General
vercel/next.js canary ijjk/next.js fix/ie11-test Change
buildDuration 13.7s 13.4s -280ms
buildDurationCached 4s 4.1s ⚠️ +37ms
nodeModulesSize 46.7 MB 46.7 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/ie11-test Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/ie11-test Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/ie11-test Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/ie11-test Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/ie11-test Change
_error.js 16.9 kB 16.9 kB ✓
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 17.2 kB 17.2 kB ⚠️ +2 B
link.js 17.4 kB 17.4 kB ✓
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB ⚠️ +2 B
Overall change 107 kB 107 kB ⚠️ +4 B
Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js fix/ie11-test Change
buildDuration 10.5s 10.9s ⚠️ +411ms
buildDurationCached 4.5s 4.7s ⚠️ +210ms
nodeModulesSize 46.7 MB 46.7 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/ie11-test Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.222 2.169 -0.05
/ avg req/sec 1125.19 1152.42 +27.23
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.185 1.133 -0.05
/error-in-render avg req/sec 2109.56 2206.06 +96.5
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/ie11-test Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.25 kB 7.25 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/ie11-test Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/ie11-test Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.38 kB 9.38 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/ie11-test Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/ie11-test Change
index.html gzip 613 B 613 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: d557d0a

@kodiakhq kodiakhq bot merged commit 0aef272 into vercel:canary May 22, 2021
@ijjk ijjk deleted the fix/ie11-test branch May 22, 2021 19:06
@sync-by-unito sync-by-unito bot mentioned this pull request May 26, 2021
Closed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@ijjk
Fix ie11 has rewrite test (vercel#25342)
e0559d9 
This updates the `rewrites-has-condition` tests to not rely on the `browser.log` method since it's not available with ie11

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
This was referenced Jul 29, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 19, 2021
Open
This was referenced Jan 12, 2022
Open
Open
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @timneutkens