Follow the breaking change of jest-config #26082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toyamarinyon
requested review from
divmain,
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
toyamarinyon
force-pushed
the
follow-the-breakingchage-of-jest-config
branch
from
e24208c to
dea07c4
Compare
leerob
previously approved these changes
Jun 16, 2021
leerob
approved these changes
Jun 16, 2021
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Jun 24, 2021
## Documentation / Examples When I create a new application using Next.js and use `jest` or `react-testing-library`, I get the following error. ``` The error below may be caused by using the wrong test environment, see https://jestjs.io/docs/configuration#testenvironment-string. Consider using the "jsdom" test environment. ReferenceError: document is not defined ``` This is because `jest-config` changed the default testing environment to node in 27.0. > `jest-config@27.0.0` default to Node testing environment instead of browser (JSDOM) (vercel#9874) Raised the jest version of `with-typescript-eslint-jest` to 27.0 to make it pass the test. - [x] Make sure the linting passes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation / Examples
When I create a new application using Next.js and use
jestorreact-testing-library, I get the following error.This is because
jest-configchanged the default testing environment to node in 27.0.Raised the jest version of
with-typescript-eslint-jestto 27.0 to make it pass the test.