URI-encode url parameter in image optimizer

[stefanprobst]

fixes #27210
maybe related: #19668

currently, the image optimizer returns 400 when an image url contains non-ascii characters. this pr uri-encodes the url query parameter to fix it. also see #27210 (comment)

Bug

• Related issues linked using fixes #number
• Integration tests added
• Errors have helpful link attached, see contributing.md

Feature

• Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
• Related issues linked using fixes #number
• Integration tests added
• Documentation added
• Telemetry added. In case of a feature if it's used or not.
• Errors have helpful link attached, see contributing.md

Documentation / Examples

• Make sure the linting passes

[styfle]

Perfect, thank you! 🎉

[ijjk]

Failing test suites

Commit: d7422dd

test/unit/webpack-config-overrides.unit.test.js

Expand output

● Test suite failed to run

/home/runner/work/next.js/next.js/packages/next/dist/build/webpack/config/blocks/css/index.js: No element indexed by 1

  at ArraySet_at [as at] (../node_modules/jest-config/node_modules/source-map/lib/array-set.js:109:9)
      at Array.map (<anonymous>)
      at run.next (<anonymous>)

[ijjk]

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	stefanprobst/next.js fix/image-optimizer-encodeuri	Change
buildDuration	15.6s	15.9s	⚠️ +223ms
buildDurationCached	3.6s	3.5s	-65ms
nodeModulesSize	50 MB	50 MB	⚠️ +182 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	stefanprobst/next.js fix/image-optimizer-encodeuri	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.648	2.696	⚠️ +0.05
/ avg req/sec	943.96	927.26	⚠️ -16.7
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.458	1.536	⚠️ +0.08
/error-in-render avg req/sec	1714.85	1628.06	⚠️ -86.79

Client Bundles (main, webpack, commons)

	vercel/next.js canary	stefanprobst/next.js fix/image-optimizer-encodeuri	Change
745.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	22.8 kB	22.8 kB	✓
webpack-HASH.js gzip	1.5 kB	1.5 kB	✓
Overall change	66.7 kB	66.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	stefanprobst/next.js fix/image-optimizer-encodeuri	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	stefanprobst/next.js fix/image-optimizer-encodeuri	Change
_app-HASH.js gzip	980 B	980 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	329 B	329 B	✓
dynamic-HASH.js gzip	2.52 kB	2.52 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	903 B	903 B	✓
image-HASH.js gzip	4.1 kB	4.1 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	319 B	319 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	12.8 kB	12.8 kB	✓

Client Build Manifests

	vercel/next.js canary	stefanprobst/next.js fix/image-optimizer-encodeuri	Change
_buildManifest.js gzip	490 B	490 B	✓
Overall change	490 B	490 B	✓

Rendered Page Sizes

	vercel/next.js canary	stefanprobst/next.js fix/image-optimizer-encodeuri	Change
index.html gzip	530 B	530 B	✓
link.html gzip	542 B	542 B	✓
withRouter.html gzip	524 B	524 B	✓
Overall change	1.6 kB	1.6 kB	✓

---

Webpack 4 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	stefanprobst/next.js fix/image-optimizer-encodeuri	Change
buildDuration	12.6s	12.4s	-209ms
buildDurationCached	4.8s	4.8s	⚠️ +7ms
nodeModulesSize	50 MB	50 MB	⚠️ +182 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	stefanprobst/next.js fix/image-optimizer-encodeuri	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.695	2.666	-0.03
/ avg req/sec	927.75	937.88	+10.13
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.483	1.496	⚠️ +0.01
/error-in-render avg req/sec	1686.17	1671.04	⚠️ -15.13

Client Bundles (main, webpack, commons)

	vercel/next.js canary	stefanprobst/next.js fix/image-optimizer-encodeuri	Change
17.HASH.js gzip	185 B	185 B	✓
677f882d2ed8..HASH.js gzip	13.8 kB	13.8 kB	✓
framework.HASH.js gzip	41.9 kB	41.9 kB	✓
main-HASH.js gzip	10.6 kB	10.6 kB	✓
webpack-HASH.js gzip	1.19 kB	1.19 kB	✓
Overall change	67.7 kB	67.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	stefanprobst/next.js fix/image-optimizer-encodeuri	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	stefanprobst/next.js fix/image-optimizer-encodeuri	Change
_app-HASH.js gzip	965 B	965 B	✓
_error-HASH.js gzip	3.74 kB	3.74 kB	✓
amp-HASH.js gzip	552 B	552 B	✓
css-HASH.js gzip	333 B	333 B	✓
dynamic-HASH.js gzip	2.71 kB	2.71 kB	✓
head-HASH.js gzip	2.97 kB	2.97 kB	✓
hooks-HASH.js gzip	911 B	911 B	✓
index-HASH.js gzip	231 B	231 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	298 B	298 B	✓
script-HASH.js gzip	2.94 kB	2.94 kB	✓
withRouter-HASH.js gzip	294 B	294 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	17.7 kB	17.7 kB	✓

Client Build Manifests

	vercel/next.js canary	stefanprobst/next.js fix/image-optimizer-encodeuri	Change
_buildManifest.js gzip	499 B	499 B	✓
Overall change	499 B	499 B	✓

Rendered Page Sizes

	vercel/next.js canary	stefanprobst/next.js fix/image-optimizer-encodeuri	Change
index.html gzip	578 B	578 B	✓
link.html gzip	591 B	591 B	✓
withRouter.html gzip	571 B	571 B	✓
Overall change	1.74 kB	1.74 kB	✓

Commit: 6d19bc2