Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "asPath" information to url objects #2988

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Add "asPath" information to url objects #2988

merged 1 commit into from
Sep 27, 2017

Conversation

gwn
Copy link
Contributor

@gwn gwn commented Sep 25, 2017

timneutkens
timneutkens reviewed Sep 26, 2017
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you use withRouter for this 🤔 Either way seems correct to have it here 👍 cc @arunoda

timneutkens
timneutkens approved these changes Sep 27, 2017
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge this

@timneutkens timneutkens merged commit 2cfcc6b into vercel:master Sep 27, 2017
@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gwn @timneutkens