Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade @typescript-eslint/parser and move to peer #30655

Closed
wants to merge 7 commits into from
Closed

upgrade @typescript-eslint/parser and move to peer #30655

wants to merge 7 commits into from

Conversation

zfben
Copy link
Contributor

@zfben zfben commented Oct 30, 2021

Bug

  • Related issues linked using fixes #number

fixes #30069

dependabot bot and others added 2 commits October 29, 2021 01:12
@dependabot
Bump node-notifier from 5.4.0 to 8.0.1
f81b770 
Bumps [node-notifier](https://github.com/mikaelbr/node-notifier) from 5.4.0 to 8.0.1.
- [Release notes](https://github.com/mikaelbr/node-notifier/releases)
- [Changelog](https://github.com/mikaelbr/node-notifier/blob/v8.0.1/CHANGELOG.md)
- [Commits](mikaelbr/node-notifier@v5.4.0...v8.0.1)

---
updated-dependencies:
- dependency-name: node-notifier
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@zfben
upgrade @typescript-eslint/parser and move to peer
c4070da
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Nov 2, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary zfben/next.js canary Change
buildDuration 21s 20.5s -544ms
buildDurationCached 4.2s 4.4s ⚠️ +246ms
nodeModulesSize 293 MB 293 MB -12 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary zfben/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.308 3.486 ⚠️ +0.18
/ avg req/sec 755.68 717.1 ⚠️ -38.58
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.817 1.839 ⚠️ +0.02
/error-in-render avg req/sec 1375.63 1359.62 ⚠️ -16.01
Client Bundles (main, webpack, commons)
vercel/next.js canary zfben/next.js canary Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 28 kB 28 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 71.9 kB 71.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary zfben/next.js canary Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary zfben/next.js canary Change
_app-HASH.js gzip 1.23 kB 1.23 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 635 B 635 B ✓
image-HASH.js gzip 4.44 kB 4.44 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.87 kB 1.87 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
334f979574ae..6f4.css gzip 106 B 106 B ✓
Overall change 13.1 kB 13.1 kB ✓
Client Build Manifests
vercel/next.js canary zfben/next.js canary Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary zfben/next.js canary Change
index.html gzip 533 B 533 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary zfben/next.js canary Change
buildDuration 21.9s 22.1s ⚠️ +220ms
buildDurationCached 4.1s 4.3s ⚠️ +151ms
nodeModulesSize 293 MB 293 MB -12 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary zfben/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.345 3.314 -0.03
/ avg req/sec 747.43 754.37 +6.94
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.747 1.886 ⚠️ +0.14
/error-in-render avg req/sec 1430.94 1325.57 ⚠️ -105.37
Client Bundles (main, webpack, commons)
vercel/next.js canary zfben/next.js canary Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.2 kB 28.2 kB ✓
webpack-HASH.js gzip 1.43 kB 1.43 kB ✓
Overall change 72.1 kB 72.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary zfben/next.js canary Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary zfben/next.js canary Change
_app-HASH.js gzip 1.22 kB 1.22 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 622 B 622 B ✓
image-HASH.js gzip 4.46 kB 4.46 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 1.91 kB 1.91 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
334f979574ae..6f4.css gzip 106 B 106 B ✓
Overall change 13.1 kB 13.1 kB ✓
Client Build Manifests
vercel/next.js canary zfben/next.js canary Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary zfben/next.js canary Change
index.html gzip 534 B 534 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: 8f8953a

@zfben
Merge pull request #4 from zfben/dependabot/npm_and_yarn/node-notifie…
36d7774 
…r-8.0.1

Bump node-notifier from 5.4.0 to 8.0.1
@housseindjirdeh
Copy link
Collaborator

Thank you for this! A separate PR (#29865) took care of upgrading @typescript-eslint/parser to v5 so I'll close this :)

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi Awaiting requested review from huozhi

@ijjk ijjk Awaiting requested review from ijjk

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@timneutkens timneutkens Awaiting requested review from timneutkens

@housseindjirdeh housseindjirdeh Awaiting requested review from housseindjirdeh

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
3 participants
@zfben @ijjk @housseindjirdeh