Fix error page doc for no server import in page #32164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molebox
requested review from
huozhi,
ijjk,
shuding and
timneutkens
as code owners
balazsorban44
requested changes
Dec 6, 2021
errors/no-server-import-in-page.md
Outdated
| @@ -2,13 +2,13 @@ | |||
|
|
|||
| ### Why This Error Occurred | |||
|
|
|||
| `next/server` was imported in a page outside of `pages/_middleware.js` (or `pages/_middleware.tsx` if you are using TypeScript) | |||
| `next/server` was imported in a page outside of `pages/_middleware.js` (or `pages/_middleware.ts`) | |||
There was a problem hiding this comment.
A _middleware can appear at any level, eg. pages/login/_middleware.{js,ts}.
Maybe use ** to indicate that?
errors/no-server-import-in-page.md
Outdated
|
|
||
| ### Possible Ways to Fix It | ||
|
|
||
| Only import and use `next/server` within `pages/_middleware.js` (or `pages/_middleware.tsx`) to add middlewares. | ||
| Only import and use `next/server` within `pages/_middleware.js` (or `pages/_middleware.ts`). |
balazsorban44
approved these changes
Dec 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a typo on the no server import in page error doc
Bug
fixes #numbercontributing.mdFeature
fixes #numbercontributing.mdDocumentation / Examples
yarn lint