Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: auto close inactive issues without reproduction #32214

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Dec 7, 2021

When a user opens a bug report, we try to verify if the problem is caused by a bug in Next.js or originates from user code/other factors.

If a reproduction is not provided, and we are unable to make an educated guess about the user implementation and possible problems we label it with please add a complete reproduction inviting the user to provide more information.

If the user does not show a sign of activity in providing any more information, the issue becomes unactionable.

With this change, we are giving users a certain amount of time before we will close such issues.

NOTE: Any action (comment, new label, edit etc.) on an issue with the label please add a complete reproduction resets the timer, and if the label is removed, the issue won't be closed anymore, until further manual inspection.

PRs are not considered through this change.

.github/workflows/stale.yml Outdated Show resolved Hide resolved
Co-authored-by: Lee Robinson <me@leerob.io>
@balazsorban44 balazsorban44 changed the title chore: close inactive issues without reproduction chore: auto close inactive issues without reproduction Dec 7, 2021
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is a great improvement.

@ijjk
Copy link
Member

ijjk commented Dec 7, 2021

Failing test suites

Commit: 12952bb

test/integration/app-document-add-hmr/test/index.test.js

  • _app/_document add HMR > should HMR when _app is added
  • _app/_document add HMR > should HMR when _document is added
Expand output

● _app/_document add HMR › should HMR when _app is added

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  16 | describe('_app/_document add HMR', () => {
  17 |   beforeAll(async () => {
> 18 |     appPort = await findPort()
     |     ^
  19 |     app = await launchApp(appDir, appPort)
  20 |   })
  21 |   afterAll(() => killApp(app))

  at integration/app-document-add-hmr/test/index.test.js:18:5
  at Object.<anonymous> (integration/app-document-add-hmr/test/index.test.js:17:1)

● _app/_document add HMR › should HMR when _document is added

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  16 | describe('_app/_document add HMR', () => {
  17 |   beforeAll(async () => {
> 18 |     appPort = await findPort()
     |     ^
  19 |     app = await launchApp(appDir, appPort)
  20 |   })
  21 |   afterAll(() => killApp(app))

  at integration/app-document-add-hmr/test/index.test.js:18:5
  at Object.<anonymous> (integration/app-document-add-hmr/test/index.test.js:17:1)

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  398 |   return new Promise((resolve, reject) => {
  399 |     const newArgs = [
> 400 |       ...args,
      |               ^
  401 |       function (err, res) {
  402 |         if (err) return reject(err)
  403 |         resolve(res)

  at Object.killApp (lib/next-test-utils.js:400:32)
  at integration/app-document-add-hmr/test/index.test.js:22:38

@ijjk
Copy link
Member

ijjk commented Dec 7, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js chore/no-repro-auto-close Change
buildDuration 18.2s 18.3s ⚠️ +83ms
buildDurationCached 3.4s 3.4s ⚠️ +12ms
nodeModulesSize 347 MB 347 MB -9 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js chore/no-repro-auto-close Change
/ failed reqs 0 0
/ total time (seconds) 3.009 2.948 -0.06
/ avg req/sec 830.9 847.94 +17.04
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.342 1.36 ⚠️ +0.02
/error-in-render avg req/sec 1862.2 1837.97 ⚠️ -24.23
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js chore/no-repro-auto-close Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js chore/no-repro-auto-close Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js chore/no-repro-auto-close Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js chore/no-repro-auto-close Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js chore/no-repro-auto-close Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js chore/no-repro-auto-close Change
buildDuration 19.5s 19.5s ⚠️ +35ms
buildDurationCached 3.3s 3.3s ⚠️ +8ms
nodeModulesSize 347 MB 347 MB -9 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js chore/no-repro-auto-close Change
/ failed reqs 0 0
/ total time (seconds) 2.992 2.951 -0.04
/ avg req/sec 835.44 847.24 +11.8
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.401 1.341 -0.06
/error-in-render avg req/sec 1784.86 1864.74 +79.88
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js chore/no-repro-auto-close Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js chore/no-repro-auto-close Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js chore/no-repro-auto-close Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js chore/no-repro-auto-close Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js chore/no-repro-auto-close Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 12952bb

@balazsorban44 balazsorban44 merged commit 68d6d1a into canary Dec 7, 2021
@balazsorban44 balazsorban44 deleted the chore/no-repro-auto-close branch December 7, 2021 15:50
stale:
runs-on: ubuntu-latest
steps:
- uses: actions/stale@main
Copy link
Member

@styfle styfle Dec 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use a tag such as @v4 instead of @main so that it won't break when newer versions are released.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Was going to change after I copied, then I forgot about it. 😬. Will address in a follow-up PR.

kodiakhq bot pushed a commit that referenced this pull request Jan 3, 2022
…#32955)

#32214 intended to only allow 30 days of stale time and then close the issue.

After studying the docs:

- https://github.com/actions/stale#days-before-issue-stale
- https://github.com/actions/stale#days-before-issue-close

and the cron job action: https://github.com/vercel/next.js/actions/runs/1647416426

I realized that we currently mark an inactive issue without reproduction as stale after 60 days and wait another 30 days before actually closing it.

With this PR, we mark issues with no reproduction as stale after 30 days and close them the day after.

This should result in a lower count of issues that are unactionable and the author seems to have moved on.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants