Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in no-page-custom-font eslint rule when default export is unnamed. #32251

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

bryanrsmith
Copy link
Contributor

fixes #32250

@ijjk

This comment has been minimized.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Dec 7, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary bryanrsmith/next.js fix-lint-crash-anonymous-export Change
buildDuration 18.3s 18.2s -158ms
buildDurationCached 3.3s 3.4s ⚠️ +49ms
nodeModulesSize 347 MB 347 MB ⚠️ +8 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary bryanrsmith/next.js fix-lint-crash-anonymous-export Change
/ failed reqs 0 0
/ total time (seconds) 3.021 2.98 -0.04
/ avg req/sec 827.67 839.05 +11.38
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.378 1.404 ⚠️ +0.03
/error-in-render avg req/sec 1814.01 1780.65 ⚠️ -33.36
Client Bundles (main, webpack, commons)
vercel/next.js canary bryanrsmith/next.js fix-lint-crash-anonymous-export Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary bryanrsmith/next.js fix-lint-crash-anonymous-export Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary bryanrsmith/next.js fix-lint-crash-anonymous-export Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary bryanrsmith/next.js fix-lint-crash-anonymous-export Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary bryanrsmith/next.js fix-lint-crash-anonymous-export Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary bryanrsmith/next.js fix-lint-crash-anonymous-export Change
buildDuration 19.5s 19.6s ⚠️ +86ms
buildDurationCached 3.4s 3.4s
nodeModulesSize 347 MB 347 MB ⚠️ +8 B
Page Load Tests Overall increase ✓
vercel/next.js canary bryanrsmith/next.js fix-lint-crash-anonymous-export Change
/ failed reqs 0 0
/ total time (seconds) 2.964 2.979 ⚠️ +0.02
/ avg req/sec 843.53 839.11 ⚠️ -4.42
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.392 1.368 -0.02
/error-in-render avg req/sec 1796.47 1827.03 +30.56
Client Bundles (main, webpack, commons)
vercel/next.js canary bryanrsmith/next.js fix-lint-crash-anonymous-export Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary bryanrsmith/next.js fix-lint-crash-anonymous-export Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary bryanrsmith/next.js fix-lint-crash-anonymous-export Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary bryanrsmith/next.js fix-lint-crash-anonymous-export Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary bryanrsmith/next.js fix-lint-crash-anonymous-export Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 9db8a07

@kodiakhq kodiakhq bot merged commit b7eeb6c into vercel:canary Dec 7, 2021
@bryanrsmith bryanrsmith deleted the fix-lint-crash-anonymous-export branch December 7, 2021 19:08
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESLint rule no-page-custom-font crashes when default export is an anonymous function
2 participants