[fix] with-apollo: Cannot read property 'data' #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we create the initial serverState, we need to create the eventual construct of the Apollo Data to reside within Later in the constructor this allows for the initApollo to either be generated from SSR, or to init from scratch. Fixes > Cannot read property 'data' of undefined > TypeError: Cannot read property 'data' of undefined
|
We could handle this in the constructor as well with a check, however, simply setting the empty object state seemed most straight forward. If we want to keep // Check if serverState is empty, and is an Object
this.apollo = (
Object.keys(this.props.serverState).length === 0 &&
this.props.serverState.constructor === Object
)
? initApollo() // No SSR render, initApollo
: initApollo(this.props.serverState.apollo.data) // SSR Render, initApollo from serverState |
No need to explicitly set `data` as empty. This trims up 4 lines. 😀️
adamsoffer
approved these changes
Nov 2, 2017
|
This looks good to me. Lets merge 👍 |
timneutkens
approved these changes
Nov 4, 2017
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create the initial
serverState, we need to create theeventual construct of the Apollo Data to reside within
Later in the constructor this allows for the
initApolloto eitherbe generated from SSR, or to init from scratch.
Fixes