Update Dockerfile #32299
Merged
Update Dockerfile #32299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `Dockerfile` to match [Next.js docs](https://nextjs.org/docs/deployment#docker-image).
abzr1
requested review from
ijjk,
leerob,
shuding and
timneutkens
as code owners
balazsorban44
approved these changes
Dec 9, 2021
ijjk
reviewed
Dec 9, 2021
| @@ -1,20 +1,20 @@ | |||
| # Install dependencies only when needed | |||
| FROM node:14-alpine AS deps | |||
There was a problem hiding this comment.
It might be good to update the docs to point to this example file so we aren't duplicating this, what do you think @molebox?
Also we should probably keep the node version locked by default so it doesn't change and break dependencies unexpectedly
There was a problem hiding this comment.
The new deployment docs remove the Dockerfile code and point directly to the example: #32006
Would appreciate reviews there!
There was a problem hiding this comment.
Also we should probably keep the node version locked by default so it doesn't change and break dependencies unexpectedly
looks like the node version has been removed unintentionally
leerob
approved these changes
Dec 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
Dockerfileto match Next.js docs.