-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RSC link navigation #32303
Fix RSC link navigation #32303
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
test/integration/react-streaming-and-server-components/test/index.test.js
Outdated
Show resolved
Hide resolved
Co-authored-by: JJ Kasper <jj@jjsweb.site>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Failing test suitesCommit: f0cf63f test/integration/amp-export-validation/test/index.test.js
Expand output● AMP Validation on Export › should have shown errors during build
● AMP Validation on Export › throws error on AMP error
● AMP Validation on Export › shows warning and error when throwing error
|
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | huozhi/next.js fix/link | Change | |
---|---|---|---|
buildDuration | 20.8s | 20.9s | |
buildDurationCached | 3.8s | 4s | |
nodeModulesSize | 351 MB | 351 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | huozhi/next.js fix/link | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.487 | 3.456 | -0.03 |
/ avg req/sec | 716.89 | 723.33 | +6.44 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.535 | 1.584 | |
/error-in-render avg req/sec | 1628.58 | 1578.25 |
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary | huozhi/next.js fix/link | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 28.8 kB | 28.8 kB | |
webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
Overall change | 72.6 kB | 72.7 kB |
Legacy Client Bundles (polyfills)
vercel/next.js canary | huozhi/next.js fix/link | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | huozhi/next.js fix/link | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.37 kB | 1.37 kB | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 326 B | 326 B | ✓ |
dynamic-HASH.js gzip | 2.39 kB | 2.39 kB | ✓ |
head-HASH.js gzip | 350 B | 350 B | ✓ |
hooks-HASH.js gzip | 919 B | 919 B | ✓ |
image-HASH.js gzip | 4.73 kB | 4.73 kB | ✓ |
index-HASH.js gzip | 263 B | 263 B | ✓ |
link-HASH.js gzip | 2.13 kB | 2.13 kB | ✓ |
routerDirect..HASH.js gzip | 321 B | 321 B | ✓ |
script-HASH.js gzip | 383 B | 383 B | ✓ |
withRouter-HASH.js gzip | 318 B | 318 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 14.1 kB | 14.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | huozhi/next.js fix/link | Change | |
---|---|---|---|
_buildManifest.js gzip | 459 B | 459 B | ✓ |
Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary | huozhi/next.js fix/link | Change | |
---|---|---|---|
index.html gzip | 531 B | 531 B | ✓ |
link.html gzip | 545 B | 544 B | -1 B |
withRouter.html gzip | 526 B | 525 B | -1 B |
Overall change | 1.6 kB | 1.6 kB | -2 B |
Diffs
Diff for main-HASH.js
@@ -1617,7 +1617,9 @@
asPathname = ref1.pathname;
var route = normalizeRoute(hrefPathname);
var getHrefForSlug = function(path) {
- if (rsc) return path + "?__flight__";
+ if (rsc) {
+ return path + search + (search ? "&" : "?") + "__flight__";
+ }
var dataRoute = (0, _getAssetPathFromRoute).default(
(0, _normalizeTrailingSlash).removePathTrailingSlash(
(0, _router).addLocale(path, locale)
Diff for index.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-b6e125a00bc99761.js"
+ src="/_next/static/chunks/main-a6d927878c4a570b.js"
defer=""
></script>
<script
Diff for link.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-b6e125a00bc99761.js"
+ src="/_next/static/chunks/main-a6d927878c4a570b.js"
defer=""
></script>
<script
Diff for withRouter.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-b6e125a00bc99761.js"
+ src="/_next/static/chunks/main-a6d927878c4a570b.js"
defer=""
></script>
<script
Default Build with SWC (Increase detected ⚠️ )
General Overall increase ⚠️
vercel/next.js canary | huozhi/next.js fix/link | Change | |
---|---|---|---|
buildDuration | 21.9s | 21.6s | -321ms |
buildDurationCached | 3.7s | 3.9s | |
nodeModulesSize | 351 MB | 351 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | huozhi/next.js fix/link | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.315 | 3.37 | |
/ avg req/sec | 754.24 | 741.77 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.533 | 1.557 | |
/error-in-render avg req/sec | 1630.38 | 1605.82 |
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary | huozhi/next.js fix/link | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.3 kB | 42.3 kB | ✓ |
main-HASH.js gzip | 29 kB | 29 kB | |
webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
Overall change | 73 kB | 73 kB |
Legacy Client Bundles (polyfills)
vercel/next.js canary | huozhi/next.js fix/link | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | huozhi/next.js fix/link | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.35 kB | 1.35 kB | ✓ |
_error-HASH.js gzip | 180 B | 180 B | ✓ |
amp-HASH.js gzip | 305 B | 305 B | ✓ |
css-HASH.js gzip | 321 B | 321 B | ✓ |
dynamic-HASH.js gzip | 2.39 kB | 2.39 kB | ✓ |
head-HASH.js gzip | 342 B | 342 B | ✓ |
hooks-HASH.js gzip | 906 B | 906 B | ✓ |
image-HASH.js gzip | 4.75 kB | 4.75 kB | ✓ |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 2.19 kB | 2.19 kB | ✓ |
routerDirect..HASH.js gzip | 314 B | 314 B | ✓ |
script-HASH.js gzip | 375 B | 375 B | ✓ |
withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 14.1 kB | 14.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | huozhi/next.js fix/link | Change | |
---|---|---|---|
_buildManifest.js gzip | 458 B | 458 B | ✓ |
Overall change | 458 B | 458 B | ✓ |
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary | huozhi/next.js fix/link | Change | |
---|---|---|---|
index.html gzip | 533 B | 531 B | -2 B |
link.html gzip | 546 B | 544 B | -2 B |
withRouter.html gzip | 527 B | 525 B | -2 B |
Overall change | 1.61 kB | 1.6 kB | -6 B |
Diffs
Diff for main-HASH.js
@@ -1617,7 +1617,9 @@
asPathname = ref1.pathname;
var route = normalizeRoute(hrefPathname);
var getHrefForSlug = function(path) {
- if (rsc) return path + "?__flight__";
+ if (rsc) {
+ return path + search + (search ? "&" : "?") + "__flight__";
+ }
var dataRoute = (0, _getAssetPathFromRoute).default(
(0, _normalizeTrailingSlash).removePathTrailingSlash(
(0, _router).addLocale(path, locale)
Diff for index.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-b6e125a00bc99761.js"
+ src="/_next/static/chunks/main-a6d927878c4a570b.js"
defer=""
></script>
<script
Diff for link.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-b6e125a00bc99761.js"
+ src="/_next/static/chunks/main-a6d927878c4a570b.js"
defer=""
></script>
<script
Diff for withRouter.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-b6e125a00bc99761.js"
+ src="/_next/static/chunks/main-a6d927878c4a570b.js"
defer=""
></script>
<script
@ijjk seems the browserlist upgration breaks the test |
@huozhi seems the AMP validation rules might have changed, the rules aren't guaranteed by semver unfortunately as it downloads them during install. |
Bug
fixes #number
contributing.md