Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added example for setting cookie before redirect in middleware #32542

Merged
merged 10 commits into from
Dec 21, 2021
Merged

Added example for setting cookie before redirect in middleware #32542

merged 10 commits into from
Dec 21, 2021

Conversation

molebox
Copy link
Collaborator

@molebox molebox commented Dec 15, 2021 •
edited
Loading

This PR adds an example for how to set a cookie before redirecting in middleware

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes: Unable to set cookie before redirect #32424
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

javivelasco
javivelasco requested changes Dec 16, 2021
View reviewed changes
docs/api-reference/next/server.md Outdated Show resolved Hide resolved
docs/api-reference/next/server.md Outdated Show resolved Hide resolved
docs/api-reference/next/server.md Outdated Show resolved Hide resolved
docs/api-reference/next/server.md Show resolved Hide resolved
docs/api-reference/next/server.md Outdated Show resolved Hide resolved
docs/api-reference/next/server.md Outdated Show resolved Hide resolved
docs/api-reference/next/server.md Show resolved Hide resolved
javivelasco
javivelasco previously approved these changes Dec 21, 2021
View reviewed changes
docs/api-reference/next/server.md Outdated Show resolved Hide resolved
docs/api-reference/next/server.md Outdated Show resolved Hide resolved
@timneutkens timneutkens merged commit 4f67edd into vercel:canary Dec 21, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer left review comments

@timneutkens timneutkens timneutkens left review comments

@javivelasco javivelasco javivelasco approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@ijjk ijjk Awaiting requested review from ijjk

@leerob leerob Awaiting requested review from leerob

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@molebox @Timer @javivelasco @timneutkens @ijjk