Update contributing guidelines for examples #32584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-tey
requested review from
huozhi,
ijjk,
shuding and
timneutkens
as code owners
leerob
reviewed
Dec 16, 2021
leerob
previously approved these changes
Dec 16, 2021
leerob
changed the title
ijjk
approved these changes
Dec 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it more clear that we're moving to TypeScript first examples, to prevent duplicate JS and TS versions and confusion around which are accepted. Further, we now have linting rules in place so you don't need to add
nameofversionfor any of the examplepackage.jsonfiles.