Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove un-needed test dependency #32616

Merged
merged 4 commits into from
Jan 3, 2022
Merged

Remove un-needed test dependency #32616

merged 4 commits into from
Jan 3, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 17, 2021

While updating a test in #28866 noticed we were using a clone dependency un-necessarily.

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Dec 17, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review December 18, 2021 01:23
@ijjk
Copy link
Member Author

ijjk commented Jan 2, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js tests/remove-dep Change
buildDuration 13.8s 13.6s -183ms
buildDurationCached 3.1s 3.1s ⚠️ +2ms
nodeModulesSize 348 MB 348 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js tests/remove-dep Change
/ failed reqs 0 0
/ total time (seconds) 2.727 2.717 -0.01
/ avg req/sec 916.66 920.25 +3.59
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.169 1.137 -0.03
/error-in-render avg req/sec 2137.69 2198.28 +60.59
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js tests/remove-dep Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27 kB 27 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.9 kB 70.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js tests/remove-dep Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js tests/remove-dep Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.74 kB 4.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js tests/remove-dep Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js tests/remove-dep Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js tests/remove-dep Change
buildDuration 15.1s 15.1s -19ms
buildDurationCached 3.1s 3.1s -5ms
nodeModulesSize 348 MB 348 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js tests/remove-dep Change
/ failed reqs 0 0
/ total time (seconds) 2.752 2.712 -0.04
/ avg req/sec 908.31 921.74 +13.43
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.137 1.158 ⚠️ +0.02
/error-in-render avg req/sec 2199.67 2159.55 ⚠️ -40.12
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js tests/remove-dep Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.1 kB 71.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js tests/remove-dep Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js tests/remove-dep Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 906 B 906 B
image-HASH.js gzip 4.76 kB 4.76 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js tests/remove-dep Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js tests/remove-dep Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: d7f553e

@ijjk ijjk merged commit c9c3183 into vercel:canary Jan 3, 2022
@ijjk ijjk deleted the tests/remove-dep branch January 3, 2022 16:08
@vercel vercel locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant