Bust cache for RSC in each render

[huozhi]

• flight response should not be cached since it's could be changed per fetching
• delete cache after readRoot has constructed react tree

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	huozhi/next.js rsc/flight-cache	Change
buildDuration	16.5s	16.4s	-66ms
buildDurationCached	3.2s	3.3s	⚠️ +61ms
nodeModulesSize	348 MB	348 MB	-221 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	huozhi/next.js rsc/flight-cache	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.714	2.711	0
/ avg req/sec	921.17	922.23	+1.06
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.157	1.137	-0.02
/error-in-render avg req/sec	2160.33	2199.73	+39.4

Client Bundles (main, webpack, commons) Overall decrease ✓

	vercel/next.js canary	huozhi/next.js rsc/flight-cache	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	30.3 kB	30.3 kB	-47 B
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	74.1 kB	74.1 kB	-47 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	huozhi/next.js rsc/flight-cache	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	huozhi/next.js rsc/flight-cache	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.37 kB	2.37 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	4.73 kB	4.73 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.13 kB	2.13 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	huozhi/next.js rsc/flight-cache	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	huozhi/next.js rsc/flight-cache	Change
index.html gzip	533 B	532 B	-1 B
link.html gzip	547 B	546 B	-1 B
withRouter.html gzip	528 B	528 B	✓
Overall change	1.61 kB	1.61 kB	-2 B

Diffs

Diff for main-HASH.js

@@ -6089,18 +6089,9 @@
           {
             key: "_getFlightData",
             value: function _getFlightData(dataHref) {
-              var _this = this;
-              var ref = new URL(dataHref, window.location.href),
-                cacheKey = ref.href;
-              if (!this.isPreview && this.sdc[cacheKey]) {
-                return Promise.resolve({
-                  fresh: false,
-                  data: this.sdc[cacheKey]
-                });
-              }
+              // Do not cache RSC flight response since it's not a static resource
               return fetchNextData(dataHref, true, true, this.sdc, false).then(
                 function(serialized) {
-                  _this.sdc[cacheKey] = serialized;
                   return {
                     fresh: true,
                     data: serialized

Diff for index.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2b7563b9671b0479.js"
+      src="/_next/static/chunks/main-e01d9e84ec169889.js"
       defer=""
     ></script>
     <script

Diff for link.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2b7563b9671b0479.js"
+      src="/_next/static/chunks/main-e01d9e84ec169889.js"
       defer=""
     ></script>
     <script

Diff for withRouter.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2b7563b9671b0479.js"
+      src="/_next/static/chunks/main-e01d9e84ec169889.js"
       defer=""
     ></script>
     <script

---

Default Build with SWC (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	huozhi/next.js rsc/flight-cache	Change
buildDuration	17.9s	17.9s	⚠️ +16ms
buildDurationCached	3.2s	3.3s	⚠️ +62ms
nodeModulesSize	348 MB	348 MB	-221 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	huozhi/next.js rsc/flight-cache	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.718	2.715	0
/ avg req/sec	919.75	920.93	+1.18
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.124	1.146	⚠️ +0.02
/error-in-render avg req/sec	2223.62	2181.54	⚠️ -42.08

Client Bundles (main, webpack, commons) Overall decrease ✓

	vercel/next.js canary	huozhi/next.js rsc/flight-cache	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	30.4 kB	30.4 kB	-28 B
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	74.3 kB	74.3 kB	-28 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	huozhi/next.js rsc/flight-cache	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	huozhi/next.js rsc/flight-cache	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.36 kB	2.36 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	906 B	906 B	✓
image-HASH.js gzip	4.75 kB	4.75 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.19 kB	2.19 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	huozhi/next.js rsc/flight-cache	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes Overall increase ⚠️

	vercel/next.js canary	huozhi/next.js rsc/flight-cache	Change
index.html gzip	530 B	531 B	⚠️ +1 B
link.html gzip	544 B	545 B	⚠️ +1 B
withRouter.html gzip	526 B	525 B	-1 B
Overall change	1.6 kB	1.6 kB	⚠️ +1 B

Diffs

Diff for main-HASH.js

@@ -6089,18 +6089,9 @@
           {
             key: "_getFlightData",
             value: function _getFlightData(dataHref) {
-              var _this = this;
-              var ref = new URL(dataHref, window.location.href),
-                cacheKey = ref.href;
-              if (!this.isPreview && this.sdc[cacheKey]) {
-                return Promise.resolve({
-                  fresh: false,
-                  data: this.sdc[cacheKey]
-                });
-              }
+              // Do not cache RSC flight response since it's not a static resource
               return fetchNextData(dataHref, true, true, this.sdc, false).then(
                 function(serialized) {
-                  _this.sdc[cacheKey] = serialized;
                   return {
                     fresh: true,
                     data: serialized

Diff for index.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2b7563b9671b0479.js"
+      src="/_next/static/chunks/main-e01d9e84ec169889.js"
       defer=""
     ></script>
     <script

Diff for link.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2b7563b9671b0479.js"
+      src="/_next/static/chunks/main-e01d9e84ec169889.js"
       defer=""
     ></script>
     <script

Diff for withRouter.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2b7563b9671b0479.js"
+      src="/_next/static/chunks/main-e01d9e84ec169889.js"
       defer=""
     ></script>
     <script

Commit: e7891dc