Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure device IP is used for safari browserstack test #32712

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Ensure device IP is used for safari browserstack test #32712

merged 1 commit into from
Dec 21, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 21, 2021 •
edited
Loading

browserstack has trouble proxying requests when localhost is used so this ensures the IP is used in the new test setup where a full URL is already provided to next-webdriver.

x-ref: https://github.com/vercel/next.js/runs/4599598602?check_suite_focus=true

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Dec 21, 2021
@ijjk ijjk marked this pull request as ready for review December 21, 2021 20:34
@ijjk ijjk requested a review from styfle December 21, 2021 20:34
@ijjk ijjk merged commit e963209 into canary Dec 21, 2021
@ijjk ijjk deleted the update/safari-test branch December 21, 2021 20:42
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@huozhi huozhi huozhi approved these changes

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijjk @styfle @huozhi