Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typescript example supporting strict w/ version >= 4.4 #33042

Merged
merged 3 commits into from
Jan 5, 2022
Merged

fix: typescript example supporting strict w/ version >= 4.4 #33042

merged 3 commits into from
Jan 5, 2022

Conversation

vicente-s
Copy link
Contributor

@vicente-s vicente-s commented Jan 5, 2022 •
edited by ijjk
Loading

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Closes: #32023
Fixes: #32015

@ijjk ijjk added the examples Issue/PR related to examples label Jan 5, 2022
@ijjk ijjk changed the title fix for issue #32015, closes #32023 fix: typescript example supporting strict w/ version >= 4.4 Jan 5, 2022
ijjk
ijjk approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kodiakhq kodiakhq bot merged commit ef7e70e into vercel:canary Jan 5, 2022
@vicente-s vicente-s deleted the vicente-s/issue-32015 branch January 5, 2022 18:12
teleaziz added a commit to teleaziz/next.js that referenced this pull request Jan 5, 2022
@teleaziz
Merge branch 'canary' of github.com:vercel/next.js into cms-builder-i…
c9fadc8 
…o-example

* 'canary' of github.com:vercel/next.js:
  [chore] Update `deta` version in examples (vercel#30204)
  fix: typescript example supporting strict w/ version >= 4.4 (vercel#33042)
  Avoid page double render with emotion vanilla (vercel#30541)
  converted the old tailwind css example to typescript  (vercel#32808)
  fix(examples/cms-contentful): add correct Content-Type + missing closing tag for html (vercel#30321)
  Ensure NODE_ENV is not inlined for next/jest (vercel#33032)
  Rename api in with-redis example (vercel#33016)
  Remove unused turbo remote cache env vars (vercel#33030)
  v12.0.8-canary.17
  Re-enable turbo caching for swc build jobs (vercel#32617)
  feat(cli): introduce `next info` CLI command (vercel#32972)
  fix(examples): add missing dependencies wo (vercel#32977)
  Updated wrong link to example of gtag init in measuring-performance.md (vercel#32974)
  v12.0.8-canary.16
  Revert "Reduce install size for linux glibc/musl (vercel#32850)" (vercel#32973)
  Ensure middleware is output in standalone mode (vercel#32967)
  v12.0.8-canary.15
  Reduce install size for linux glibc/musl (vercel#32850)
  Fixes issue with makeStylesheetInert (vercel#32027)
  Ensure setImmediate and punycode are polyfilled (vercel#32768)
@balazsorban44
Copy link
Member

Thank you @vicente-s!

@vicente-s
Copy link
Contributor Author

@balazsorban44 It was my pleasure, really couldn't of done it without your help! Definitely looking forward to making more contributions.

@vercel vercel locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@leerob leerob Awaiting requested review from leerob

@shuding shuding Awaiting requested review from shuding

@steven-tey steven-tey Awaiting requested review from steven-tey

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetStaticProps type error using latest TypeScript version with strict option set to true
3 participants
@vicente-s @balazsorban44 @ijjk