Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable import assertion syntax parsing #33750

Merged
merged 5 commits into from
Mar 6, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jan 27, 2022

Feature

Enable import assertion syntax parsing for ecmascript/typescript. Since webpack has already supported it, enable import assertion parsing and leave them to webpack to handle

Upgration

  • tooling: @swc/core, @swc/cli, prettier to support importAssertion related flags
  • typescript related: typescript >= 4.5
  • babel related: @babel/plugin-syntax-import-assertions
  • lint parser: @typescript-eslint/parser

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 27, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@huozhi huozhi marked this pull request as ready for review February 4, 2022 19:40
padmaia
padmaia previously approved these changes Feb 4, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

kdy1
kdy1 previously approved these changes Feb 7, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc options LGTM

@ijjk

This comment has been minimized.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this increased install size by ⚠️ +2.34 MB which might be related to the @babel/parser ncc change 🤔

@huozhi huozhi dismissed stale reviews from kdy1 and padmaia via 353e109 February 8, 2022 00:26
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment was marked as outdated.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@huozhi huozhi marked this pull request as ready for review March 3, 2022 23:28
@huozhi
Copy link
Member Author

huozhi commented Mar 3, 2022

@ijjk The size increase are caused by inline source maps by swc, which is not enabled by default in previous version. fixed

@huozhi huozhi requested review from ijjk, padmaia and kdy1 March 3, 2022 23:29
kdy1
kdy1 previously approved these changes Mar 3, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The options passed to swc looks good to me.

@ijjk

This comment has been minimized.

@ijjk ijjk added the examples Issue/PR related to examples label Mar 6, 2022
@ijjk

This comment has been minimized.

@huozhi huozhi removed the examples Issue/PR related to examples label Mar 6, 2022
@ijjk
Copy link
Member

ijjk commented Mar 6, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js enable-import-assertion Change
buildDuration 15.2s 15.2s -8ms
buildDurationCached 6.1s 6.2s ⚠️ +71ms
nodeModulesSize 375 MB 372 MB -2.31 MB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js enable-import-assertion Change
/ failed reqs 0 0
/ total time (seconds) 2.924 2.923 0
/ avg req/sec 855.02 855.29 +0.27
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.193 1.189 0
/error-in-render avg req/sec 2095.4 2102.18 +6.78
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js enable-import-assertion Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js enable-import-assertion Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js enable-import-assertion Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.06 kB 5.06 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.8 kB 14.8 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js enable-import-assertion Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js enable-import-assertion Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js enable-import-assertion Change
buildDuration 18.7s 18.7s -30ms
buildDurationCached 6.1s 6.1s -1ms
nodeModulesSize 375 MB 372 MB -2.31 MB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js enable-import-assertion Change
/ failed reqs 0 0
/ total time (seconds) 2.903 2.911 ⚠️ +0.01
/ avg req/sec 861.22 858.84 ⚠️ -2.38
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.18 1.164 -0.02
/error-in-render avg req/sec 2119.44 2148.67 +29.23
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js enable-import-assertion Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js enable-import-assertion Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js enable-import-assertion Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.2 kB 5.2 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.9 kB 14.9 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js enable-import-assertion Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js enable-import-assertion Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 0d10aa1

@kodiakhq kodiakhq bot merged commit ff6b750 into vercel:canary Mar 6, 2022
@huozhi huozhi deleted the enable-import-assertion branch March 6, 2022 21:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants