Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle de-duping revalidations in minimal mode #34935

Merged
merged 8 commits into from
Mar 2, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 1, 2022

When in minimal mode the incremental cache is disabled so ISR pages are revalidated synchronously, when revalidating the HTML page and the data back-to-back we can re-use the previous cache by storing this in memory temporarily.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Mar 1, 2022
@ijjk

This comment has been minimized.

@ijjk ijjk requested a review from Timer March 2, 2022 19:52
@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review March 2, 2022 21:54
Timer
Timer previously approved these changes Mar 2, 2022
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Mar 2, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/minimal-mode-isr-deduping Change
buildDuration 18.1s 17.7s -355ms
buildDurationCached 7s 6.9s -74ms
nodeModulesSize 372 MB 372 MB ⚠️ +2.27 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/minimal-mode-isr-deduping Change
/ failed reqs 0 0
/ total time (seconds) 3.535 3.523 -0.01
/ avg req/sec 707.3 709.64 +2.34
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.561 1.539 -0.02
/error-in-render avg req/sec 1601.43 1624.72 +23.29
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js add/minimal-mode-isr-deduping Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/minimal-mode-isr-deduping Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/minimal-mode-isr-deduping Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.06 kB 5.06 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.8 kB 14.8 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/minimal-mode-isr-deduping Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/minimal-mode-isr-deduping Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/minimal-mode-isr-deduping Change
buildDuration 21s 21.1s ⚠️ +95ms
buildDurationCached 6.9s 6.8s -102ms
nodeModulesSize 372 MB 372 MB ⚠️ +2.27 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js add/minimal-mode-isr-deduping Change
/ failed reqs 0 0
/ total time (seconds) 3.522 3.571 ⚠️ +0.05
/ avg req/sec 709.83 700.12 ⚠️ -9.71
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.549 1.581 ⚠️ +0.03
/error-in-render avg req/sec 1614.42 1581.43 ⚠️ -32.99
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js add/minimal-mode-isr-deduping Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.1 kB 28.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/minimal-mode-isr-deduping Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/minimal-mode-isr-deduping Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.2 kB 5.2 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.9 kB 14.9 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/minimal-mode-isr-deduping Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/minimal-mode-isr-deduping Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 6f8a326

@ijjk ijjk merged commit 81c50f4 into vercel:canary Mar 2, 2022
@ijjk ijjk deleted the add/minimal-mode-isr-deduping branch March 2, 2022 23:06
kodiakhq bot pushed a commit to vercel/vercel that referenced this pull request Mar 6, 2022
…bridge (#7507)

### Related Issues

x-ref: vercel/next.js#34935

### 📋 Checklist

<!--
  Please keep your PR as a Draft until the checklist is complete
-->

#### Tests

- [ ] The code changed/added as part of this PR has been covered with tests
- [ ] All tests pass locally with `yarn test-unit`

#### Code Review

- [ ] This PR has a concise title and thorough description useful to a reviewer
- [ ] Issue from task tracker has a link to this PR
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants