Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix animated png bypass from Image Optimization API #35120

Merged
merged 4 commits into from
Mar 7, 2022
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented Mar 7, 2022

@ijjk
Copy link
Member

ijjk commented Mar 7, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-animated-png2 Change
buildDuration 15.2s 15s -225ms
buildDurationCached 6.1s 6.1s -44ms
nodeModulesSize 372 MB 372 MB ⚠️ +24 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix-animated-png2 Change
/ failed reqs 0 0
/ total time (seconds) 2.936 2.959 ⚠️ +0.02
/ avg req/sec 851.52 844.76 ⚠️ -6.76
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.186 1.19 0
/error-in-render avg req/sec 2108.33 2101.4 ⚠️ -6.93
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix-animated-png2 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-animated-png2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix-animated-png2 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.09 kB 5.09 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.8 kB 14.8 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-animated-png2 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-animated-png2 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-animated-png2 Change
buildDuration 18.4s 18.4s -11ms
buildDurationCached 6s 6s -84ms
nodeModulesSize 372 MB 372 MB ⚠️ +24 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix-animated-png2 Change
/ failed reqs 0 0
/ total time (seconds) 2.911 2.934 ⚠️ +0.02
/ avg req/sec 858.88 852.15 ⚠️ -6.73
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.167 1.189 ⚠️ +0.02
/error-in-render avg req/sec 2142.49 2101.77 ⚠️ -40.72
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix-animated-png2 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-animated-png2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix-animated-png2 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.23 kB 5.23 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15 kB 15 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-animated-png2 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-animated-png2 Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: fe170c0

@kodiakhq kodiakhq bot merged commit b25f7f8 into canary Mar 7, 2022
@kodiakhq kodiakhq bot deleted the fix-animated-png2 branch March 7, 2022 20:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image component change animated files to static ones
2 participants