Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watch node_modules #35140

Merged
merged 1 commit into from
Mar 8, 2022
Merged

watch node_modules #35140

merged 1 commit into from
Mar 8, 2022

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 8, 2022

next.js doesn't HMR when installing node_modules.

This fixes it.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk
Copy link
Member

ijjk commented Mar 8, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js bugfix/watch-node-modules Change
buildDuration 16.7s 16.8s ⚠️ +12ms
buildDurationCached 6.3s 6.4s ⚠️ +82ms
nodeModulesSize 372 MB 372 MB -41 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js bugfix/watch-node-modules Change
/ failed reqs 0 0
/ total time (seconds) 3.245 3.288 ⚠️ +0.04
/ avg req/sec 770.39 760.31 ⚠️ -10.08
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.459 1.458 0
/error-in-render avg req/sec 1712.98 1714.97 +1.99
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bugfix/watch-node-modules Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/watch-node-modules Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/watch-node-modules Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.09 kB 5.09 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.8 kB 14.8 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/watch-node-modules Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/watch-node-modules Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js bugfix/watch-node-modules Change
buildDuration 20.1s 19.9s -126ms
buildDurationCached 6.3s 6.3s ⚠️ +21ms
nodeModulesSize 372 MB 372 MB -41 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js bugfix/watch-node-modules Change
/ failed reqs 0 0
/ total time (seconds) 3.215 3.217 0
/ avg req/sec 777.66 777.2 ⚠️ -0.46
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.421 1.417 0
/error-in-render avg req/sec 1759.68 1764.85 +5.17
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bugfix/watch-node-modules Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/watch-node-modules Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/watch-node-modules Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.23 kB 5.23 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15 kB 15 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/watch-node-modules Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/watch-node-modules Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 117be1f

@kodiakhq kodiakhq bot merged commit 292636d into canary Mar 8, 2022
@kodiakhq kodiakhq bot deleted the bugfix/watch-node-modules branch March 8, 2022 14:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants