Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests against node LTS (v16) and current (v17) #35414

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 17, 2022

This updates to start testing against both the LTS version of node and the current version for all of our tests instead of specific ones. Since our integration tests rely on dependencies on the monorepo this can cause conflicts depending on the version so these will be updated in a separate PR.

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Mar 17, 2022
@ijjk
Copy link
Member Author

ijjk commented Mar 17, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js update/node-test-coverage Change
buildDuration 18.3s 18.2s -83ms
buildDurationCached 7.4s 7.4s -29ms
nodeModulesSize 456 MB 456 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/node-test-coverage Change
/ failed reqs 0 0
/ total time (seconds) 3.643 3.544 -0.1
/ avg req/sec 686.23 705.35 +19.12
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.596 1.558 -0.04
/error-in-render avg req/sec 1566.72 1604.11 +37.39
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/node-test-coverage Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/node-test-coverage Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/node-test-coverage Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/node-test-coverage Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/node-test-coverage Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js update/node-test-coverage Change
buildDuration 21.8s 21.4s -400ms
buildDurationCached 6.8s 7.1s ⚠️ +290ms
nodeModulesSize 456 MB 456 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/node-test-coverage Change
/ failed reqs 0 0
/ total time (seconds) 3.574 3.732 ⚠️ +0.16
/ avg req/sec 699.49 669.93 ⚠️ -29.56
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.54 1.603 ⚠️ +0.06
/error-in-render avg req/sec 1623.8 1559.61 ⚠️ -64.19
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/node-test-coverage Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/node-test-coverage Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/node-test-coverage Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/node-test-coverage Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/node-test-coverage Change
index.html gzip 531 B 531 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 31799b1

@ijjk ijjk marked this pull request as ready for review March 17, 2022 21:44
@ijjk ijjk merged commit 4365463 into vercel:canary Mar 17, 2022
@ijjk ijjk deleted the update/node-test-coverage branch March 17, 2022 22:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants