-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CI build cache instructions to Deployment docs #35418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that we want to surface these steps outside of the errors page (good catch!) but we'll want to either:
- Move this into its own page (it's long)
- Condense and link to instructions from providers (I worry these are already out of date)
We're working to restructure this page of the docs as well, so let me think about this a bit more while we figure that out. Appreciate the contribution.
@leerob that makes a lot of sense. I wonder if it would be helpful to add a provider-agnostic strategy for invalidating E.g. "invalidate the Next.js cache if dependencies change or source files change" etc. |
Hey @leerob! Do you think it would be alright in the meantime to have this update go through as is? Reason being that folks can still benefit from this information being in the docs, even if it is eventually reorganized. Right now, this info doesn't exist in the docs anywhere, so just adding it in the first place would be really helpful. |
|
Co-authored-by: Lee Robinson <me@leerob.io>
@leerob I was able to incorporate your requested changes – feel free to take a look and merge whenever you are ready! |
@leerob / @timneutkens – I think this PR is ready to go! 🚀 Please let me know if there are any other changes I should make! |
Hi folks! Would you like me to close this PR? It has been several months and I haven't heard from anyone, so I'll plan on closing this PR a week from today if there is no word. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Sorry for the delay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR moves the instructions for configuring CI providers to preserve Next.js's build cache out of the No Cache Detected error message and into
the Deploymenta new page within the Advanced Features docs.This change is beneficial because it makes the CI configuration examples visible in the context of other helpful documentation for deploying Next.js.
👉 Prior to this change, these CI configuration examples didn't show up in the Next.js docs.
The relocated instructions are now linked on the No Cache Detected error message page.
Documentation / Examples
yarn lint