Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y: Set focus back to body after link was clicked #3545

Merged
merged 3 commits into from
Jan 25, 2018
Merged

A11y: Set focus back to body after link was clicked #3545

merged 3 commits into from
Jan 25, 2018

Conversation

connor-baer
Copy link
Contributor

Solves #2768.

When navigating from one page to another using next/link, set the focus on the <body> on the new page as the document root. This reflects the behavior when navigating with a normal <a> link.

@connor-baer
Copy link
Contributor Author

connor-baer commented Jan 22, 2018 •
edited
Loading

@timneutkens @sergiodxa, would you mind reviewing this PR, please? 🙂
(FYI, failing checks are unrelated to this PR)

timneutkens
timneutkens approved these changes Jan 25, 2018
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright 👍 Sorry it took a while, we're working on shipping v5 which involves a lot of internal changes to Next.js. We also always thoroughly review pull requests by running them ourselves and adding tests for them 👍

@timneutkens timneutkens merged commit 8dd8e20 into vercel:canary Jan 25, 2018
@timneutkens
Copy link
Member

Thanks for your contribution 🙏

@connor-baer connor-baer mentioned this pull request Jan 25, 2018
Closed
1 task
@connor-baer
Copy link
Contributor Author

connor-baer commented Jan 25, 2018 •
edited
Loading

Thank you @timneutkens! 😊 I applaud your thoroughness. 👏

@mgiraldo mgiraldo mentioned this pull request Mar 14, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connor-baer @timneutkens