-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added with-particles template #35471
Conversation
Co-authored-by: Balázs Orbán <info@balazsorban.com>
Co-authored-by: Balázs Orbán <info@balazsorban.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I added some small comments.
Another question, what's the correct way of referring to the library? I see the directory was named with-particles
, but the package is called react-tsparticles
, the website https://particles.js.org/ says "TS Particles" (while the page title is tsParticles).
The reason I'm asking is that there is a https://vincentgarreau.com/particles.js/ so to not confuse developers, maybe we should call the directory with-tsparticles
? What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing my comments, could we also convert this example to TypeScript?
@balazsorban44 Another example or just convert this one to TS? It's not a problem either way |
Converting this to TypeScript should be enough. 👍 |
Converted 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Documentation / Examples
yarn lint