Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hydration issue in the switchable runtime tests #35616

Merged
merged 3 commits into from
Mar 27, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented Mar 26, 2022

In this test we are mainly focusing on the SSR'd result so hydration is't critical, but it will definitely help to get rid of these hydration errors.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Mar 26, 2022
@ijjk

This comment was marked as resolved.

@shuding shuding marked this pull request as draft March 26, 2022 13:17
@ijjk

This comment has been minimized.

@shuding shuding marked this pull request as ready for review March 26, 2022 15:51
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Mar 27, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary shuding/next.js shu/1670 Change
buildDuration 21.6s 21.8s ⚠️ +201ms
buildDurationCached 8.3s 8.2s -28ms
nodeModulesSize 467 MB 467 MB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/1670 Change
/ failed reqs 0 0
/ total time (seconds) 4.668 4.58 -0.09
/ avg req/sec 535.56 545.86 +10.3
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.354 2.173 -0.18
/error-in-render avg req/sec 1061.84 1150.66 +88.82
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/1670 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/1670 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/1670 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/1670 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/1670 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary shuding/next.js shu/1670 Change
buildDuration 26.3s 26.2s -93ms
buildDurationCached 8.3s 8.2s -72ms
nodeModulesSize 467 MB 467 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/1670 Change
/ failed reqs 0 0
/ total time (seconds) 4.643 4.688 ⚠️ +0.04
/ avg req/sec 538.47 533.24 ⚠️ -5.23
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.253 2.29 ⚠️ +0.04
/error-in-render avg req/sec 1109.77 1091.91 ⚠️ -17.86
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/1670 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/1670 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/1670 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/1670 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/1670 Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 7f1478e

@kodiakhq kodiakhq bot merged commit bb6ea63 into vercel:canary Mar 27, 2022
@shuding shuding deleted the shu/1670 branch March 27, 2022 13:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants