Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to customize jest transformIgnorePatterns #35635

Closed
wants to merge 1 commit into from

Conversation

crubier
Copy link

@crubier crubier commented Mar 27, 2022

Fixes #35634

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

testPathIgnorePatterns: [
testPathIgnorePatterns: resolvedJestConfig.testPathIgnorePatterns || [
Copy link

@burtek burtek Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#35634 and this PR title say about transformIgnorePatterns, yet PR itself changes testPathIgnorePatterns?

@ijjk
Copy link
Member

ijjk commented Apr 13, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary crubier/next.js patch-1 Change
buildDuration 15.3s 15.3s ⚠️ +31ms
buildDurationCached 6.1s 6s -72ms
nodeModulesSize 467 MB 467 MB -276 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary crubier/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 3.005 3.013 ⚠️ +0.01
/ avg req/sec 832 829.61 ⚠️ -2.39
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.162 1.161 0
/error-in-render avg req/sec 2151.19 2152.5 +1.31
Client Bundles (main, webpack)
vercel/next.js canary crubier/next.js patch-1 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72 kB 72 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary crubier/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary crubier/next.js patch-1 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary crubier/next.js patch-1 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary crubier/next.js patch-1 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary crubier/next.js patch-1 Change
buildDuration 18.7s 18.7s -2ms
buildDurationCached 6.2s 6.2s ⚠️ +15ms
nodeModulesSize 467 MB 467 MB -276 B
Page Load Tests Overall increase ✓
vercel/next.js canary crubier/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 3.022 3.021 0
/ avg req/sec 827.26 827.46 +0.2
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.192 1.164 -0.03
/error-in-render avg req/sec 2097.79 2148.5 +50.71
Client Bundles (main, webpack)
vercel/next.js canary crubier/next.js patch-1 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary crubier/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary crubier/next.js patch-1 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.77 kB 5.77 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 394 B 394 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary crubier/next.js patch-1 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary crubier/next.js patch-1 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 6f74264

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I think after further investigation in #36787 we want to leave the overriding as is for these configs and then if further overriding is needed then the returned config can be modified as shown in this comment

Thanks for the PR though!

@ijjk ijjk closed this May 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next/Jest : Cannot override transformIgnorePatterns
3 participants