Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): worker execution failed with custom next.config.js #37125

Merged
merged 8 commits into from
May 23, 2022

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented May 23, 2022

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

The PR fixes #37122, an issue introduced by #37105.

next.config.js might/will include functions (custom webpack, generateBuildId, exportPathsMap, etc.) that are not able to pass from the main thread to a worker. The PR fixes the issue by only passing primitive args to the worker.

@ijjk
Copy link
Member

ijjk commented May 23, 2022

Failing test suites

Commit: 17c8133

yarn testheadless test/integration/async-modules/test/index.test.js

  • Async modules > production mode > can render async AMP pages
  • Async modules > serverless mode > can render async AMP pages
Expand output

● Async modules › production mode › can render async AMP pages

TIMED OUT: just now

28 seconds ago

  498 |
  499 |   if (hardError) {
> 500 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  501 |   }
  502 |   return false
  503 | }

  at Object.check (lib/next-test-utils.js:500:11)
  at Object.<anonymous> (integration/async-modules/test/index.test.js:85:7)

● Async modules › serverless mode › can render async AMP pages

TIMED OUT: just now

24 seconds ago

  498 |
  499 |   if (hardError) {
> 500 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  501 |   }
  502 |   return false
  503 | }

  at Object.check (lib/next-test-utils.js:500:11)
  at Object.<anonymous> (integration/async-modules/test/index.test.js:85:7)

Read more about building and testing Next.js in contributing.md.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented May 23, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary SukkaW/next.js fix-next-config-worker Change
buildDuration 17.3s 16.3s -1s
buildDurationCached 6.7s 6.8s ⚠️ +172ms
nodeModulesSize 479 MB 479 MB ⚠️ +293 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary SukkaW/next.js fix-next-config-worker Change
/ failed reqs 0 0
/ total time (seconds) 3.788 4.105 ⚠️ +0.32
/ avg req/sec 659.97 609.04 ⚠️ -50.93
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.421 1.52 ⚠️ +0.1
/error-in-render avg req/sec 1759.78 1644.66 ⚠️ -115.12
Client Bundles (main, webpack)
vercel/next.js canary SukkaW/next.js fix-next-config-worker Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary SukkaW/next.js fix-next-config-worker Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary SukkaW/next.js fix-next-config-worker Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary SukkaW/next.js fix-next-config-worker Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary SukkaW/next.js fix-next-config-worker Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary SukkaW/next.js fix-next-config-worker Change
buildDuration 18.4s 19s ⚠️ +654ms
buildDurationCached 6.8s 6.7s -71ms
nodeModulesSize 479 MB 479 MB ⚠️ +293 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary SukkaW/next.js fix-next-config-worker Change
/ failed reqs 0 0
/ total time (seconds) 3.932 4.255 ⚠️ +0.32
/ avg req/sec 635.82 587.56 ⚠️ -48.26
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.462 1.537 ⚠️ +0.07
/error-in-render avg req/sec 1709.41 1626.74 ⚠️ -82.67
Client Bundles (main, webpack)
vercel/next.js canary SukkaW/next.js fix-next-config-worker Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.7 kB 29.7 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 74.1 kB 74.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary SukkaW/next.js fix-next-config-worker Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary SukkaW/next.js fix-next-config-worker Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.82 kB 5.82 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary SukkaW/next.js fix-next-config-worker Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary SukkaW/next.js fix-next-config-worker Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 1d964d4

@kodiakhq kodiakhq bot merged commit e57e275 into vercel:canary May 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2022
@SukkaW SukkaW deleted the fix-next-config-worker branch October 24, 2023 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript + exprimental.workerThreads might cause build fail [Next.js 12.1.7-canary.11 only]
2 participants