-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deploy E2E test setup #37126
Merged
Merged
Update deploy E2E test setup #37126
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
01f37ce
Update deploy E2E test setup
ijjk 9d49cb5
fix typo
ijjk 756bd87
update
ijjk d54d386
bump
ijjk 66dbf19
update
ijjk e66299b
fix var
ijjk 039f49d
specific test
ijjk 4822b74
run all
ijjk 51662ff
debug
ijjk 16254df
update test
ijjk 9ba82d9
Merge branch 'canary' into fix/e2e-deploy
ijjk 6739160
log
ijjk d841dc5
use test binary
ijjk 4a4239e
update config
ijjk 145fcc5
stabilize test
ijjk 22b2166
update test
ijjk 46280e9
Merge branch 'canary' into fix/e2e-deploy
ijjk 5c48345
undo test check
ijjk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,7 +46,9 @@ if (testModeFromFile === 'e2e') { | |
const validE2EModes = ['dev', 'start', 'deploy'] | ||
|
||
if (!process.env.NEXT_TEST_JOB && !testMode) { | ||
console.warn('Warn: no NEXT_TEST_MODE set, using default of start') | ||
require('console').warn( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Whats the purpose of require() here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it bypasses jest delaying the logs from being emitted, x-ref: #35507 |
||
'Warn: no NEXT_TEST_MODE set, using default of start' | ||
) | ||
testMode = 'start' | ||
} | ||
assert( | ||
|
@@ -74,7 +76,9 @@ if (!testMode) { | |
`No 'NEXT_TEST_MODE' set in environment, this is required for e2e-utils` | ||
) | ||
} | ||
console.log(`Using test mode: ${testMode} in test folder ${testModeFromFile}`) | ||
require('console').warn( | ||
`Using test mode: ${testMode} in test folder ${testModeFromFile}` | ||
) | ||
|
||
/** | ||
* FileRef is wrapper around a file path that is meant be copied | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to merge this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this will need to be investigated separately