Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pnpm link to docs #37221

Merged
merged 4 commits into from
May 27, 2022
Merged

add pnpm link to docs #37221

merged 4 commits into from
May 27, 2022

Conversation

appsbytom
Copy link
Contributor

@appsbytom appsbytom commented May 26, 2022

Documentation / Examples

  • Make sure the linting passes by running yarn lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label May 26, 2022
lachlanjc
lachlanjc previously approved these changes May 26, 2022
Copy link
Contributor

@lachlanjc lachlanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In favor of adding an Oxford comma but like this improvement!

contributing.md Outdated Show resolved Hide resolved
@ijjk
Copy link
Member

ijjk commented May 27, 2022

Stats from current PR

Default Build
General
vercel/next.js canary appsbytom/next.js pnpm-documentation-link Change
buildDuration 16.3s 16.2s -103ms
buildDurationCached 6.5s 6.4s -58ms
nodeModulesSize 626 MB 626 MB
Page Load Tests Overall increase ✓
vercel/next.js canary appsbytom/next.js pnpm-documentation-link Change
/ failed reqs 0 0
/ total time (seconds) 3.931 3.912 -0.02
/ avg req/sec 635.93 639 +3.07
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.369 1.371 0
/error-in-render avg req/sec 1826.08 1824.01 ⚠️ -2.07
Client Bundles (main, webpack)
vercel/next.js canary appsbytom/next.js pnpm-documentation-link Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 72.9 kB 72.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary appsbytom/next.js pnpm-documentation-link Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary appsbytom/next.js pnpm-documentation-link Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary appsbytom/next.js pnpm-documentation-link Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary appsbytom/next.js pnpm-documentation-link Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary appsbytom/next.js pnpm-documentation-link Change
buildDuration 18.5s 18.6s ⚠️ +92ms
buildDurationCached 6.4s 6.4s ⚠️ +19ms
nodeModulesSize 626 MB 626 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary appsbytom/next.js pnpm-documentation-link Change
/ failed reqs 0 0
/ total time (seconds) 3.923 3.956 ⚠️ +0.03
/ avg req/sec 637.34 631.9 ⚠️ -5.44
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.38 1.394 ⚠️ +0.01
/error-in-render avg req/sec 1811.91 1793.56 ⚠️ -18.35
Client Bundles (main, webpack)
vercel/next.js canary appsbytom/next.js pnpm-documentation-link Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.7 kB 29.7 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 74 kB 74 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary appsbytom/next.js pnpm-documentation-link Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary appsbytom/next.js pnpm-documentation-link Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.9 kB 2.9 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.84 kB 5.84 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.4 kB 16.4 kB
Client Build Manifests
vercel/next.js canary appsbytom/next.js pnpm-documentation-link Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary appsbytom/next.js pnpm-documentation-link Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 8be3359

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle merged commit 3e178bb into vercel:canary May 27, 2022
@appsbytom appsbytom deleted the pnpm-documentation-link branch May 30, 2022 09:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants