-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge Functions: deprecate access to request.page
#37349
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
# Deprecated page into Middleware API | ||
|
||
#### Why This Error Occurred | ||
|
||
Your application is interacting with `request.page`, and it's being deprecated. | ||
|
||
```typescript | ||
// middleware.ts | ||
import { NextRequest, NextResponse } from 'next/server' | ||
|
||
export function middleware(request: NextRequest) { | ||
const { params } = event.request.page | ||
const { locale, slug } = params | ||
|
||
if (locale && slug) { | ||
const { search, protocol, host } = request.nextUrl | ||
const url = new URL(`${protocol}//${locale}.${host}/${slug}${search}`) | ||
return NextResponse.redirect(url) | ||
} | ||
} | ||
``` | ||
|
||
#### Possible Ways to Fix It | ||
|
||
You can use [URLPattern](https://developer.mozilla.org/en-US/docs/Web/API/URLPattern) instead to have the same behavior: | ||
|
||
```typescript | ||
// middleware.ts | ||
import { NextRequest, NextResponse } from 'next/server' | ||
|
||
const PATTERNS = [ | ||
[ | ||
new URLPattern({ pathname: '/:locale/:slug' }), | ||
({ pathname }) => pathname.groups, | ||
], | ||
] | ||
|
||
const params = (url) => { | ||
const input = url.split('?')[0] | ||
let result = {} | ||
|
||
for (const [pattern, handler] of PATTERNS) { | ||
const patternResult = pattern.exec(input) | ||
if (patternResult !== null && 'pathname' in patternResult) { | ||
result = handler(patternResult) | ||
break | ||
} | ||
} | ||
return result | ||
} | ||
|
||
export function middleware(request: NextRequest) { | ||
const { locale, slug } = params(request.url) | ||
|
||
if (locale && slug) { | ||
const { search, protocol, host } = request.nextUrl | ||
const url = new URL(`${protocol}//${locale}.${host}/${slug}${search}`) | ||
return NextResponse.redirect(url) | ||
} | ||
} | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add ts comment
@deprecated
notion for this? so it's known as deprecated through typingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good point; I never did that before, let me open a new PR 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's being mentioned as deprecated in runtime but I think the text should be strikethrough.
not sure why that is still exported since we can't use it anymore in next12.2
and also I have a question. what will be the good replacement for this
req.page.name
in my case, I want to get the dynamic routes folder name like
pages/[customer]
. I used to do this withreq.page.name