Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ESLint upgrade instructions to middleware upgrade guide #38008

Merged
merged 5 commits into from
Jun 27, 2022
Merged

Added ESLint upgrade instructions to middleware upgrade guide #38008

merged 5 commits into from
Jun 27, 2022

Conversation

steven-tey
Copy link
Contributor

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk mentioned this pull request Jun 25, 2022
Merged
3 tasks
@kodiakhq kodiakhq bot closed this in #38009 Jun 25, 2022
kodiakhq bot pushed a commit that referenced this pull request Jun 25, 2022
@ijjk
Fix eslint-config-next peer dep issue (#38009)
f4fb3e0 
It seems `npm` fails to resolve the `next` `peerDependencies` field for `eslint-config-next` and this field isn't necessarily needed so this removes it to ensure upgrading doesn't require the `--force` flag.  

## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

Fixes: #38008 (comment)
@ijjk ijjk reopened this Jun 25, 2022
@balazsorban44
Copy link
Member

See #38008 (comment)

@kodiakhq kodiakhq bot merged commit 8019cf0 into canary Jun 27, 2022
@kodiakhq kodiakhq bot deleted the upgrade-guide-with-eslint branch June 27, 2022 00:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 left review comments

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steven-tey @balazsorban44 @ijjk