Feature: Allow user to set rewriteSecure: false for rewrites function in next configs
#38786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow user to set `secure: false` for rewrites function in next config
e752938
requested review from
huozhi,
ijjk,
shuding and
timneutkens
as code owners
ijjk
reviewed
Aug 8, 2022
Member
ijjk
left a comment
ijjk
left a comment
There was a problem hiding this comment.
Hi, I'm not sure we want to make this a global config in next.config.js as it could be very easy to set this and accidentally leave it for production. Potentially we could have an experimental config to allow specific rewrite destinations to use secure: false.
I'm gonna close this for now although we can continue investigating this on the mentioned discussion.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of people got this
UNABLE_TO_VERIFY_LEAF_SIGNATUREerror when using rewrites function to external https url: https://github.com/vercel/next.js/search?q=unable+to+verify+the+first+certificate (and more if you google it...We should add an option for users to ignore this error during development. Like this one proposed: #28334
Then user can set
rewriteSecure: falseinnext.config.jsfile to ignore this type of error.