Make sure hot-self-accept-loader cleans up the route correctly #4092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
commented
Mar 31, 2018
| @@ -177,15 +177,18 @@ export default async function getBaseWebpackConfig (dir, {dev = false, isServer | |||
| module: { | |||
| rules: [ | |||
| dev && !isServer && { | |||
| test: /\.(js|jsx)(\?[^?]*)?$/, | |||
| test: /\.(js|jsx)$/, | |||
There was a problem hiding this comment.
Also made sure these are consistent and simple.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across this while investigating #3894, this is important for users of next-typescript and people using
.jsx.When this is merged I'll update next-typescript. I've added the throw in the loader since we need everyone that's going to use Next 6 to upgrade next-typescript