Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with-reasonml: use default exports #4217

Merged
merged 1 commit into from
Apr 27, 2018
Merged

with-reasonml: use default exports #4217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/with-reasonml/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"name": "with-reasonml",
"version": "1.0.0",
"scripts": {
"dev": "concurrently \"bsb -clean-world -make-world -w\" \"next -w\"",
"build": "bsb -clean-world -make-world && next build",
"start": "bsb -clean-world -make-world && next start -w"
"dev": "bsb -clean-world -make-world && next dev lib/js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should actually use https://github.com/reasonml-community/bs-loader 🤔

Copy link
Contributor Author

@rase- rase- Apr 27, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably could. I'm experimenting with that separately right now actually.

Don't think it's necessary for this PR tho. Already a nice incremental improvement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not bs-loader exactly, since it's deprecated, but a similarly smoother set up here could work, that is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah definitely 👍

"build": "bsb -clean-world -make-world && next build lib/js",
"start": "next start lib/js"
},
"license": "ISC",
"dependencies": {
Expand Down
4 changes: 0 additions & 4 deletions examples/with-reasonml/pages/about.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion examples/with-reasonml/pages/About.re → examples/with-reasonml/pages/about.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ let make = (_children) => {
</div>
};

let jsComponent = ReasonReact.wrapReasonForJs(~component, (_jsProps) => make([||]));
let default = ReasonReact.wrapReasonForJs(~component, (_jsProps) => make([||]));
3 changes: 0 additions & 3 deletions examples/with-reasonml/pages/index.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion examples/with-reasonml/pages/Index.re → examples/with-reasonml/pages/index.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ let make = (_children) => {
</div>
};

let jsComponent = ReasonReact.wrapReasonForJs(~component, (_jsProps) => make([||]));
let default = ReasonReact.wrapReasonForJs(~component, (_jsProps) => make([||]));