Don’t use chunkhash in development #4436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a test for the issue @rauchg ran into with dynamic imports. Tested locally on canary the test fails, after this patch it passes. |
lependu
pushed a commit
to lependu/next.js
that referenced
this pull request
Jun 19, 2018
* Don’t use chunkhash in development * Add test for dynamic imports styling * Remove pre-load of dynamic page * Make sure the browser gets closed only once
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recommended by both Tobias and Kees from the webpack core team in serval issues, one of them is: webpack/webpack-dev-server#377 (comment)
Also fixes a race condition with styled-jsx CSS changes not being hot reloaded on the server.