Remove unnecessary environment check in lib/app.js #4655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
reviewed
Jun 23, 2018
| if (process.env.NODE_ENV !== 'production') { | ||
| warn(`Warning: the 'url' property is deprecated. https://err.sh/next.js/url-deprecated`) | ||
| } | ||
| warn(`Warning: the 'url' property is deprecated. https://err.sh/next.js/url-deprecated`) |
There was a problem hiding this comment.
This is totally necessary. We only want to log this in development.
There was a problem hiding this comment.
lib/utils.js (Lines 2-4) handles it, doesn’t it?
There was a problem hiding this comment.
Also this makes sure we compile it out using webpack, instead of leaving the warn code in production it's compiled away.
There was a problem hiding this comment.
Was thinking that it handles and can remove unnecessary check. Sorry :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello :)
I have removed unnecessary environment check from
lib/app.js(Lines 81-85), sincelib/utils.js(Lines 2-4) already have it.