Update swc_core to v0.75.23
#48098
Merged
Update swc_core to v0.75.23
#48098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padmaia
requested review from
timneutkens,
ijjk,
shuding,
a team,
huozhi and
feedthejim
as code owners
ijjk
added
Turbopack
jridgewell
previously approved these changes
Apr 7, 2023
Failing test suitesCommit: 9274d5a
Expand output● single child ● multiple child with default legacyBehavior ● multiple child with forced legacyBehavior=false Read more about building and testing Next.js in contributing.md. |
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
🚮 Removed packages: @swc/core@1.2.203 |
kdy1
force-pushed
the
kdy1/swc-0-74
branch
2 times, most recently
from
7507ba3 to
3c38896
Compare
kdy1
reviewed
Apr 8, 2023
| @@ -199,7 +199,7 @@ async function postProcessHTML( | |||
| : null, | |||
| process.env.NEXT_RUNTIME !== 'edge' && renderOpts.optimizeFonts | |||
| ? async (html: string) => { | |||
| const getFontDefinition = (url: string): string => { | |||
| const getFontDefinition = (url: string) => { | |||
There was a problem hiding this comment.
Will be fixed by swc-project/swc#7232
kdy1
force-pushed
the
kdy1/swc-0-74
branch
2 times, most recently
from
769229d to
5b9ccf5
Compare
|
any updates? |
Investigationexport const NextDynamicNoSSRServerComponent = dynamic(
() => import('../text-dynamic-no-ssr-server'),
{
ssr: false,
}
)this is the cause, and it works if I remove |
Further investigation:
|
kdy1
force-pushed
the
kdy1/swc-0-74
branch
2 times, most recently
from
c63e80d to
21bbd46
Compare
Further investigation:
|
InvestigationSome modules in ssrModuleMapping
clientModules(next.js part)
(e2e test app part)
|
sokra
previously approved these changes
Apr 18, 2023
kdy1
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
vercel/turborepo#4470 is approved/merged along with this PR
sokra
added a commit
that referenced
this pull request
Apr 18, 2023
### What? swc_core dependencies update ### Why? follow-up from #48098
|
Hello, was hoping to get some assistance with an issue that I believe this PR introduced in When a component contained a hook like import * as NextNavigation from 'next/navigation';
describe('test...', () => {
it('should...', () => {
const pathname = cy.stub().as('usePathname').returns('/en/public');
cy.stub(NextNavigation, 'usePathname').returns(pathname());
})
})This approach worked for me up until this canary version was release. Now it throws the following error: Does anyone have a suggestion on how to resolve this? |
|
Update: for those who come across this as well, I managed to solve by creating my own mount function specifically for components that depend on these hooks. Here's an abbreviated implementation: import { MountOptions, MountReturn, mount } from 'cypress/react18';
import { AppRouterContext } from 'next/dist/shared/lib/app-router-context';
import { PathnameContext } from 'next/dist/shared/lib/hooks-client-context';
declare global {
namespace Cypress {
interface Chainable {
mount: typeof mount;
nextMount: (jsx: React.ReactNode, options?: Partial<MountOptions & {
pathname?: string;
}>) => Chainable<MountReturn>;
}
}
}
Cypress.Commands.add('mount', mount);
Cypress.Commands.add('nextMount', (component, options) => {
const router = {
back: cy.stub().as('router:back'),
forward: cy.stub().as('router:forward'),
prefetch: cy.stub().as('router:prefetch'),
push: cy.stub().as('router:push'),
reload: cy.stub().as('router:reload'),
refresh: cy.stub().as('router:refresh'),
replace: cy.stub().as('router:replace')
};
const pathname = options?.pathname ?? '/';
return mount(
<AppRouterContext.Provider value={ router }>
<PathnameContext.Provider value={ pathname }>
{ component }
</PathnameContext.Provider>
</AppRouterContext.Provider>
);
}); |
1 task
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on vercel/turborepo#4470
next buildwith 13.2.4 #46989