Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typing of resolve metadata #48670

Merged
merged 8 commits into from
Apr 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions packages/next/src/lib/metadata/generate/utils.ts
Original file line number Diff line number Diff line change
@@ -1,20 +1,17 @@
function resolveArray<T>(value: T): T[] {
function resolveArray<T>(value: T | T[]): T[] {
if (Array.isArray(value)) {
return value
return value as any
}
return [value]
return [value] as any
}

function resolveAsArrayOrUndefined<T extends unknown | readonly unknown[]>(
function resolveAsArrayOrUndefined<T>(
value: T | T[] | undefined | null
): undefined | T[] {
): T extends undefined | null ? undefined : T[] {
if (typeof value === 'undefined' || value === null) {
return undefined
return undefined as any
}
if (Array.isArray(value)) {
return value
}
return [value]
return resolveArray(value) as any
}

export { resolveAsArrayOrUndefined, resolveArray }
9 changes: 5 additions & 4 deletions packages/next/src/lib/metadata/resolve-metadata.ts
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,12 @@ function merge({
case 'archives':
case 'assets':
case 'bookmarks':
case 'keywords':
case 'keywords': {
target[key] = resolveAsArrayOrUndefined(source[key])
break
}
case 'authors': {
// FIXME: type inferring
// @ts-ignore
target[key] = resolveAsArrayOrUndefined(source[key]) || null
target[key] = resolveAsArrayOrUndefined(source.authors)
break
}
// directly assign fields that fallback to null
Expand Down
2 changes: 1 addition & 1 deletion packages/next/src/lib/metadata/resolvers/resolve-basics.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ function resolveUrlValuesOfObject(
if (typeof value === 'string' || value instanceof URL) {
result[key] = [
{
url: resolveAlternateUrl(value, metadataBase, pathname), // metadataBase ? resolveUrl(value, metadataBase)! : value,
url: resolveAlternateUrl(value, metadataBase, pathname),
},
]
} else {
Expand Down