Bump eslint-plugin-import to 2.27.5 to benefit from default export overload fix #50054
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasHubelbauer
requested review from
timneutkens,
ijjk,
shuding,
huozhi and
feedthejim
as code owners
…erload fix Hi, I noticed Next is using eslint-plugin-import@2.22.1 and I would like to propose bumping that to 2.27.5 since that version fixes an issue where a default export with overloads is incorrectly identified as multiple default exports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I noticed Next is using eslint-plugin-import@2.22.1 and I would like to propose bumping that to 2.27.5 since that version fixes an issue where a default export with overloads is incorrectly identified as multiple default exports.
import-js/eslint-plugin-import#1590
None of the sections in the template match, I am just bumping a dependency which will fix an edge case Next users might run into, but I don't think it counts as a bugfix because there was never a bug in Next. I removed the template but I can return it if people think I should treat it as a bugfix and fill in that section of the template.