Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code that is no longer in use #5147

Merged
merged 3 commits into from
Sep 12, 2018
Merged

Remove code that is no longer in use #5147

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89084cc
Remove handleBuildId as it’s being handled in the static files route
timneutkens Sep 12, 2018
947850e
Remove dead code
timneutkens Sep 12, 2018
bd53914
Merge branch 'canary' into fix/remove-handle-build-id
leo Sep 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions server/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,20 +352,6 @@ export default class Server {
return buildId.trim()
}

handleBuildId (buildId, res) {
if (this.dev) {
res.setHeader('Cache-Control', 'no-store, must-revalidate')
return true
}

if (buildId !== this.renderOpts.buildId) {
return false
}

res.setHeader('Cache-Control', 'public, max-age=31536000, immutable')
return true
}

async getCompilationError (page) {
if (!this.hotReloader) return

Expand All @@ -375,9 +361,4 @@ export default class Server {
// Return the very first error we found.
return errors[0]
}

send404 (res) {
res.statusCode = 404
res.end('404 - Not Found')
}
}