Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for wasm #5316

Merged
merged 10 commits into from
Oct 2, 2018
Merged

Support for wasm #5316

merged 10 commits into from
Oct 2, 2018

Conversation

AndyBitz
Copy link
Contributor

@AndyBitz AndyBitz commented Sep 27, 2018

Together with webpack/webpack-sources#42 and gajus/write-file-webpack-plugin#71 it fixes #5277

It sets the default wasm module name to static/wasm/[modulehash].wasm and adds the mime type application/wasm.

@timneutkens
Copy link
Member

Awesome 🙌 we should also upgrade the write-file-webpack-plugin right? As you made a PR to that?

@AndyBitz
Copy link
Contributor Author

Yes, but it isn't published to npm yet.

@timneutkens
Copy link
Member

@gajus sorry for pinging you out of nowhere, but could you do a new release of write-file-webpack-plugin? Then we can fix webassembly support in development with Next.js 👍🙌 Thank you very much in advance ❤️

@gajus
Copy link

gajus commented Sep 27, 2018

@gajus sorry for pinging you out of nowhere, but could you do a new release of write-file-webpack-plugin? Then we can fix webassembly support in development with Next.js 👍🙌 Thank you very much in advance ❤️

Done.

@timneutkens
Copy link
Member

Awesome! Thanks 🙌

@timneutkens
Copy link
Member

Hmm interestingly appveyor is failing

@AndyBitz
Copy link
Contributor Author

Hmm, the previous merge worked

Maybe it has something to do with this: Build execution time has reached the maximum allowed time for your plan (60 minutes).?

@timneutkens timneutkens merged commit b041fa4 into vercel:canary Oct 2, 2018
@timneutkens
Copy link
Member

Merged this, but I think we still have to upgrade write-file-webpack-plugin

@AndyBitz AndyBitz deleted the support-for-wasm branch October 2, 2018 11:16
@lock lock bot locked as resolved and limited conversation to collaborators Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot load wasm files; compiling stucks at 98%
3 participants