Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update link.js #533

Closed
wants to merge 2 commits into from
Closed

Update link.js #533

wants to merge 2 commits into from

Conversation

suhaotian
Copy link
Contributor

Then we can write like this

<Link href="/about" className="about" style={{color: 'red'}}>About</Link>

arunoda
arunoda suggested changes Dec 27, 2016
View reviewed changes
Copy link
Contributor

@arunoda arunoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. this is good.
You need to fix some lint issues.
Run this:

npm run lint -- --fix

@suhaotian
Copy link
Contributor Author

@arunoda
Nothing happen
image

arunoda
arunoda suggested changes Dec 27, 2016
View reviewed changes
Copy link
Contributor

@arunoda arunoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this.

lib/link.js
const props = {
onClick: this.linkClicked
onClick: this.linkClicked,
...rest,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove this comma here.

@arunoda
Copy link
Contributor

arunoda commented Dec 27, 2016

@suhaotian weird.
Check my above comment.

@suhaotian
Copy link
Contributor Author

@arunoda Hey, does right?

@nkzawa
Copy link
Contributor

nkzawa commented Dec 27, 2016

I believe we don't want to support this. See #272 cc @rauchg

@suhaotian
Copy link
Contributor Author

@nkzawa ok

@suhaotian suhaotian closed this Dec 27, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arunoda arunoda arunoda requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suhaotian @arunoda @nkzawa