Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return true to prefetch #559

Closed
wants to merge 1 commit into from
Closed

Conversation

timneutkens
Copy link
Member

Fixes '#540'

This avoids unintended bugs because you'd expect the function to return something instead of 'void'

@nkzawa
Copy link
Contributor

nkzawa commented Dec 29, 2016

We wouldn't like to return true here. I think void rather makes sense, or a promise which is resolved when prefetching finished ?

@timneutkens
Copy link
Member Author

Makes sense, will change it

@arunoda
Copy link
Contributor

arunoda commented Dec 29, 2016

@nkzawa I think it's kind a hard to identify prefetching finished event with the current setup.
We may need to do few more stuff.
But I am not sure, that's something worthy to do.

@arunoda
Copy link
Contributor

arunoda commented Dec 29, 2016

I think we could fix #540 without changing anything here.

@timneutkens
Copy link
Member Author

@arunoda fair enough, will change the example then 👍

@timneutkens timneutkens deleted the #540 branch December 29, 2016 12:52
@arunoda
Copy link
Contributor

arunoda commented Dec 29, 2016

Thanks @timneutkens
I think we already landed a fix :)
#563

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants