-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ensurePage for client-side navigation to / in Turbopack #56704
Merged
kodiakhq
merged 2 commits into
canary
from
10-11-Fix_ensurePage_for_client-side_navigation_to_/_in_turbopack
Oct 12, 2023
Merged
Fix ensurePage for client-side navigation to / in Turbopack #56704
kodiakhq
merged 2 commits into
canary
from
10-11-Fix_ensurePage_for_client-side_navigation_to_/_in_turbopack
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
ijjk,
shuding,
huozhi,
feedthejim,
ztanner,
wyattjoh and
a team
as code owners
October 11, 2023 13:20
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
timneutkens
changed the title
Fix ensurePage for client-side navigation to / in turbopack
Fix ensurePage for client-side navigation to / in Turbopack
Oct 11, 2023
Tests Passed |
Stats from current PRDefault BuildGeneral Overall increase
|
vercel/next.js canary | vercel/next.js 10-11-Fix_ensurePage_for_client-side_navigation_to_/_in_turbopack | Change | |
---|---|---|---|
buildDuration | 10.7s | 10.7s | N/A |
buildDurationCached | 6.5s | 6.5s | N/A |
nodeModulesSize | 172 MB | 172 MB | |
nextStartRea..uration (ms) | 898ms | 895ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js 10-11-Fix_ensurePage_for_client-side_navigation_to_/_in_turbopack | Change | |
---|---|---|---|
199-HASH.js gzip | 27.5 kB | 27.5 kB | N/A |
3f784ff6-HASH.js gzip | 50.9 kB | 50.9 kB | ✓ |
99.HASH.js gzip | 182 B | 182 B | ✓ |
framework-HASH.js gzip | 45.3 kB | 45.3 kB | ✓ |
main-app-HASH.js gzip | 254 B | 252 B | N/A |
main-HASH.js gzip | 32.9 kB | 32.9 kB | N/A |
webpack-HASH.js gzip | 1.75 kB | 1.75 kB | N/A |
Overall change | 96.4 kB | 96.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js 10-11-Fix_ensurePage_for_client-side_navigation_to_/_in_turbopack | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js 10-11-Fix_ensurePage_for_client-side_navigation_to_/_in_turbopack | Change | |
---|---|---|---|
_app-HASH.js gzip | 206 B | 205 B | N/A |
_error-HASH.js gzip | 182 B | 180 B | N/A |
amp-HASH.js gzip | 506 B | 505 B | N/A |
css-HASH.js gzip | 322 B | 323 B | N/A |
dynamic-HASH.js gzip | 2.57 kB | 2.57 kB | N/A |
edge-ssr-HASH.js gzip | 260 B | 259 B | N/A |
head-HASH.js gzip | 350 B | 350 B | ✓ |
hooks-HASH.js gzip | 369 B | 369 B | ✓ |
image-HASH.js gzip | 4.35 kB | 4.35 kB | N/A |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 2.64 kB | 2.63 kB | N/A |
routerDirect..HASH.js gzip | 312 B | 311 B | N/A |
script-HASH.js gzip | 385 B | 384 B | N/A |
withRouter-HASH.js gzip | 307 B | 308 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 1.08 kB | 1.08 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js 10-11-Fix_ensurePage_for_client-side_navigation_to_/_in_turbopack | Change | |
---|---|---|---|
_buildManifest.js gzip | 485 B | 482 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js 10-11-Fix_ensurePage_for_client-side_navigation_to_/_in_turbopack | Change | |
---|---|---|---|
index.html gzip | 528 B | 530 B | N/A |
link.html gzip | 541 B | 543 B | N/A |
withRouter.html gzip | 523 B | 525 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js 10-11-Fix_ensurePage_for_client-side_navigation_to_/_in_turbopack | Change | |
---|---|---|---|
edge-ssr.js gzip | 93.7 kB | 93.7 kB | N/A |
page.js gzip | 152 kB | 152 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js 10-11-Fix_ensurePage_for_client-side_navigation_to_/_in_turbopack | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 627 B | 624 B | N/A |
middleware-r..fest.js gzip | 150 B | 151 B | N/A |
middleware.js gzip | 22.9 kB | 22.9 kB | N/A |
edge-runtime..pack.js gzip | 1.92 kB | 1.92 kB | ✓ |
Overall change | 1.92 kB | 1.92 kB | ✓ |
jridgewell
approved these changes
Oct 11, 2023
…ation_to_/_in_turbopack
kodiakhq
bot
deleted the
10-11-Fix_ensurePage_for_client-side_navigation_to_/_in_turbopack
branch
October 12, 2023 08:38
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating the failing test case of
test/integration/scroll-forward-restoration/test/index.test.js
I found that navigating from/another
to/
usingnext/link
with ahref="/"
errored onensurePage
as "this page was not built". Turns normalization wasn't applied on these so the inputpage
was/index
instead of/
, where it expects/
as the input.