Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip webpack specific tests in Turbopack test run #56877

Merged

Conversation

timneutkens
Copy link
Member

Looked for webpack(config in the test suites and disabled the ones that are testing webpack specifically. There are a few more that are not skipped as they should be implemented for Turbopack.

@timneutkens timneutkens requested review from S3Prototype and lydiahallie and removed request for a team October 16, 2023 10:07
@ijjk ijjk added area: tests created-by: Next.js team PRs by the Next.js team. labels Oct 16, 2023
@timneutkens
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ijjk
Copy link
Member

ijjk commented Oct 16, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js 10-16-Skip_webpack_specific_tests_in_Turbopack_test_run Change
buildDuration 10.3s 10.4s N/A
buildDurationCached 6.4s 6.3s N/A
nodeModulesSize 172 MB 172 MB
nextStartRea..uration (ms) 507ms 509ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 10-16-Skip_webpack_specific_tests_in_Turbopack_test_run Change
199-HASH.js gzip 27.5 kB 27.5 kB N/A
3f784ff6-HASH.js gzip 50.9 kB 50.9 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.3 kB 45.3 kB
main-app-HASH.js gzip 252 B 252 B
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 96.7 kB 96.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 10-16-Skip_webpack_specific_tests_in_Turbopack_test_run Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 10-16-Skip_webpack_specific_tests_in_Turbopack_test_run Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.35 kB 4.35 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.08 kB 1.08 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 10-16-Skip_webpack_specific_tests_in_Turbopack_test_run Change
_buildManifest.js gzip 485 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 10-16-Skip_webpack_specific_tests_in_Turbopack_test_run Change
index.html gzip 529 B 530 B N/A
link.html gzip 542 B 542 B
withRouter.html gzip 524 B 525 B N/A
Overall change 542 B 542 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 10-16-Skip_webpack_specific_tests_in_Turbopack_test_run Change
edge-ssr.js gzip 93.7 kB 93.7 kB N/A
page.js gzip 152 kB 152 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 10-16-Skip_webpack_specific_tests_in_Turbopack_test_run Change
middleware-b..fest.js gzip 623 B 624 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.5 kB 22.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: af1271b

@kodiakhq kodiakhq bot merged commit 4e435e2 into canary Oct 16, 2023
57 checks passed
@kodiakhq kodiakhq bot deleted the 10-16-Skip_webpack_specific_tests_in_Turbopack_test_run branch October 16, 2023 10:34
@github-actions github-actions bot added the locked label Nov 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants