Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: reduce fs-extra usage in scripts/" #56962

Closed
wants to merge 1 commit into from

Conversation

styfle
Copy link
Member

@styfle styfle commented Oct 17, 2023

Reverts #56917 since its failing on windows

❌ packages/font/src/google/get-font-axes.test.ts output:
packages/font/src/google/get-font-axes.test.ts failed to pass within 0 retries
IS_RETRY=undefined RECORD_REPLAY=undefined HEADLESS=true TRACE_PLAYWRIGHT=true NEXT_TELEMETRY_DISABLED=1 CI= CIRCLECI= GITHUB_ACTIONS= CONTINUOUS_INTEGRATION= RUN_ID= BUILD_NUMBER= JEST_JUNIT_OUTPUT_NAME=packages_font_src_google_get-font-axes.test.ts JEST_SUITE_NAME=dev:unit:packages/font/src/google/get-font-axes.test.ts D:\a\1\s\node_modules\.bin\jest.CMD '--runInBand' '--forceExit' '--verbose' '--silent' 'packages/font/src/google/get-font-axes.test.ts'
   Downloading swc package @next/swc-win32-x64-msvc...
node:internal/process/promises:288
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[Error: EPERM: operation not permitted, rename 'C:\Users\VssAdministrator\AppData\Local\next-swc\swc-win32-x64-msvc-13.5.6-canary.3.tgz.temp-1697574492235' -> 'C:\Users\VssAdministrator\AppData\Local\next-swc\swc-win32-x64-msvc-13.5.6-canary.3.tgz'] {
  errno: -4048,
  code: 'EPERM',
  syscall: 'rename',
  path: 'C:\\Users\\VssAdministrator\\AppData\\Local\\next-swc\\swc-win32-x64-msvc-13.5.6-canary.3.tgz.temp-1697574492235',
  dest: 'C:\\Users\\VssAdministrator\\AppData\\Local\\next-swc\\swc-win32-x64-msvc-13.5.6-canary.3.tgz'
}

https://dev.azure.com/nextjs/next.js/_build/results?buildId=70758&view=logs&j=8af7cf9c-43a1-584d-6f5c-57bad8880974&t=7ae70e63-3625-50f4-6764-5b3e72b4bd7a

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Oct 17, 2023
@ijjk
Copy link
Member

ijjk commented Oct 17, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js revert-56917-scripts-fs-extra Change
buildDuration 11.8s 10.7s N/A
buildDurationCached 6.9s 6.2s N/A
nodeModulesSize 174 MB 174 MB
nextStartRea..uration (ms) 556ms 516ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js revert-56917-scripts-fs-extra Change
199-HASH.js gzip 27.5 kB 27.5 kB
3f784ff6-HASH.js gzip 53.1 kB 53.1 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.3 kB 45.3 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 126 kB 126 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-56917-scripts-fs-extra Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js revert-56917-scripts-fs-extra Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.35 kB 4.35 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.08 kB 1.08 kB
Client Build Manifests
vercel/next.js canary vercel/next.js revert-56917-scripts-fs-extra Change
_buildManifest.js gzip 485 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js revert-56917-scripts-fs-extra Change
index.html gzip 528 B 530 B N/A
link.html gzip 541 B 542 B N/A
withRouter.html gzip 523 B 524 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js revert-56917-scripts-fs-extra Change
edge-ssr.js gzip 93.6 kB 93.6 kB N/A
page.js gzip 154 kB 154 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js revert-56917-scripts-fs-extra Change
middleware-b..fest.js gzip 626 B 622 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.5 kB 22.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: 59eddd3

@styfle
Copy link
Member Author

styfle commented Oct 17, 2023

Hmm, not so sure this is the culprit since I see other PRs passing. Closing for now.

@styfle styfle closed this Oct 17, 2023
@styfle styfle deleted the revert-56917-scripts-fs-extra branch October 17, 2023 21:15
@SukkaW
Copy link
Contributor

SukkaW commented Oct 18, 2023

@styfle IMHO we only need to revert the fse.move from the fsp.rename (which is flaky on windows). I can create a PR for that.

@github-actions github-actions bot added the locked label Nov 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants