Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra CI step and lock Node.js version #57769

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 30, 2023

Seems this command is causing intermittent issues and we don't actually need this information so removes it

@ijjk ijjk requested review from a team as code owners October 30, 2023 17:01
@ijjk ijjk requested review from jh3y and lydiahallie and removed request for a team October 30, 2023 17:01
@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Oct 30, 2023
feedthejim
feedthejim previously approved these changes Oct 30, 2023
@ijjk
Copy link
Member Author

ijjk commented Oct 30, 2023

Stats from current PR

Default Build
General
vercel/next.js canary ijjk/next.js ci/remove-extra-step Change
buildDuration 10s 10.2s ⚠️ +137ms
buildDurationCached 6s 6s N/A
nodeModulesSize 175 MB 175 MB
nextStartRea..uration (ms) 418ms 421ms N/A
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js ci/remove-extra-step Change
199-HASH.js gzip 30 kB 30 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 251 B N/A
main-HASH.js gzip 33.1 kB 33.1 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.9 kB 98.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js ci/remove-extra-step Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js ci/remove-extra-step Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js ci/remove-extra-step Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js ci/remove-extra-step Change
index.html gzip 529 B 529 B
link.html gzip 542 B 543 B N/A
withRouter.html gzip 524 B 525 B N/A
Overall change 529 B 529 B
Edge SSR bundle Size
vercel/next.js canary ijjk/next.js ci/remove-extra-step Change
edge-ssr.js gzip 96.1 kB 96.1 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary ijjk/next.js ci/remove-extra-step Change
middleware-b..fest.js gzip 624 B 624 B
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 23 kB 23 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.55 kB 2.55 kB
Commit: 6eabec7

@ijjk ijjk requested a review from feedthejim October 30, 2023 17:13
@ijjk ijjk changed the title Remove extra CI step Remove extra CI step and lock Node.js version Oct 30, 2023
@kodiakhq kodiakhq bot merged commit 676d1ee into vercel:canary Oct 30, 2023
51 of 56 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants