Enable typechecking on config

[karlhorky]

What?

Enable TS type-checking on config for reproduction templates

Why?

Using JSDoc type on module.exports doesn't work in TypeScript currently:

• JSDoc: module.exports direct literal assignment not type checked microsoft/TypeScript#51819
• JSDoc type annotations on module.exports assignments not type checked microsoft/TypeScript#47107

create-next-app already fixed this:

• commit by @ijjk 4151283 (part of PR Add types to nextConfig in default template  #34029)

How?

Create intermediate nextConfig variable and annotate that with JSDoc type

Prior Art

Also done in rspack-website over here:

• https://github.com/web-infra-dev/rspack-website/pull/286
• fix: Fix type checking in config examples web-infra-dev/rspack#2965

cc @balazsorban44

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: 524b24f

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: 79aeb9d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[karlhorky]

@balazsorban44 thanks for the approval. I guess CI is currently broken in canary, can we merge this as-is?

[balazsorban44]

The merging process is automatic. It might take a bit but will be merged.

[karlhorky]

The merging process is automatic

ah nice, fancy. I hope I didn't break that automatic process by hitting the "Update branch" button to merge from canary (which created a new merge commit after your approval)

[karlhorky]

@balazsorban44 it seems this still hasn't been automatically merged.

Should I do something? Or can you, from your side?

[karlhorky]

@balazsorban44 Seems like the only thing that is failing now is the Datadog failure, seemingly unrelated to this PR:

Run actions/download-artifact@v3
Starting download for test-reports
Error: Unable to find an artifact with the name: test-reports

What do you think of ignoring the CI error and merging as is?

[karlhorky]

Thanks for the review and merge @balazsorban44 @huozhi 🙌