Dedupe only items with unique key #5800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
rauchg
approved these changes
Dec 3, 2018
JeromeFitz
added a commit
to JeromeFitz/next-seo
that referenced
this pull request
Jan 6, 2019
`next@7.0.2-canary.35` was the implementation - Dedupe only items with unique key: [5800](vercel/next.js#5800) In upgrading all the packges in this PR, some versions were not working (not sure why). I've tested with the latest `canary` from `next` and everything is passing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3705
Fixes #4656
key=""behavior, making sure that if a unique key is provided tags are deduped based on that.For example:
Would currently cause
After this change:
Then if you use next/head multiple times / want to be able to override:
Would cause:
As
keygets deduped correctly after this PR, similar to how React itself works.